Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: extensions/renderer/module_system_test.cc

Issue 1632763003: Fix leaks in exensions_unittests after enabling Oilpan (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system_test.cc
diff --git a/extensions/renderer/module_system_test.cc b/extensions/renderer/module_system_test.cc
index 68c4bd1fedbea1ba0756956cf5a14423eca2e402..50de79fe954fb4adb62c484aac81fc2e32634df9 100644
--- a/extensions/renderer/module_system_test.cc
+++ b/extensions/renderer/module_system_test.cc
@@ -22,6 +22,7 @@
#include "extensions/renderer/object_backed_native_handler.h"
#include "extensions/renderer/safe_builtins.h"
#include "extensions/renderer/utils_native_handler.h"
+#include "third_party/WebKit/public/web/WebHeap.h"
#include "ui/base/resource/resource_bundle.h"
namespace extensions {
@@ -240,6 +241,7 @@ void ModuleSystemTest::TearDown() {
old_heap_size = stats.used_heap_size();
isolate_->RequestGarbageCollectionForTesting(
v8::Isolate::kFullGarbageCollection);
+ blink::WebHeap::collectAllGarbageForTesting();
sof 2016/01/26 06:09:43 The v8 major GC will trigger Oilpan GCs also, so u
sof 2016/01/26 08:05:44 https://build.chromium.org/p/chromium.memory.fyi/b
haraken 2016/01/26 08:26:40 Doesn't collectAllGarbage always collect more obje
isolate_->GetHeapStatistics(&stats);
}
}
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698