Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 1632673004: Get rid of a redundant parameter ResetCaretBlinkOption from FrameSelection::updateAppearance() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-01-26T14:38:54 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index 12e06d1a06b7466a8f776189e843e1d3722d73e1..e53345ce6de1355ff100417fc09e7dc497208a30 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -91,11 +91,6 @@ public:
return static_cast<EUserTriggered>(options & UserTriggered);
}
- enum ResetCaretBlinkOption {
- None,
- ResetCaretBlink
- };
-
LocalFrame* frame() const { return m_frame; }
Element* rootEditableElement() const { return selection().rootEditableElement(); }
Element* rootEditableElementOrDocumentElement() const;
@@ -186,7 +181,7 @@ public:
bool isAppearanceDirty() const;
void commitAppearanceIfNeeded(LayoutView&);
- void updateAppearance(ResetCaretBlinkOption = None);
+ void updateAppearance();
void setCaretVisible(bool caretIsVisible) { setCaretVisibility(caretIsVisible ? Visible : Hidden); }
bool isCaretBoundsDirty() const { return m_caretRectDirty; }
void setCaretRectNeedsUpdate();
@@ -281,6 +276,7 @@ private:
void focusedOrActiveStateChanged();
void caretBlinkTimerFired(Timer<FrameSelection>*);
+ void stopCaretBlinkTimer();
void setUseSecureKeyboardEntry(bool);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698