Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 1632673004: Get rid of a redundant parameter ResetCaretBlinkOption from FrameSelection::updateAppearance() (Closed)

Created:
4 years, 11 months ago by yosin_UTC9
Modified:
4 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of a redundant parameter ResetCaretBlinkOption from FrameSelection::updateAppearance() This patch gets rid of rid of a redundant parameter |ResetCaretBlinkOption| from |FrameSelection::updateAppearance()| with introducing |stopCaretBlinkTimer()| by calling |stopCaretBlinkTimer()| at call site which calls |updateAppearance()| with |ResetCaretBlink| to simplify source code for improving readability. This patch is a follow-up patch of http://crrev.com/1629213002, which simplifies code path in |updateAppearance()|. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/013af3f06c0c8d9d7b5bb52421ddff41a697f0bb Cr-Commit-Position: refs/heads/master@{#371472}

Patch Set 1 : 2016-01-26T14:38:54 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632673004/1
4 years, 11 months ago (2016-01-26 05:41:23 UTC) #3
yosin_UTC9
PTAL
4 years, 11 months ago (2016-01-26 07:10:54 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 07:11:44 UTC) #8
yoichio
lgtm
4 years, 11 months ago (2016-01-26 07:22:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632673004/1
4 years, 11 months ago (2016-01-26 07:29:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 07:37:35 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 07:38:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/013af3f06c0c8d9d7b5bb52421ddff41a697f0bb
Cr-Commit-Position: refs/heads/master@{#371472}

Powered by Google App Engine
This is Rietveld 408576698