Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 16326004: Revert 204014 "Don't track whether a resize ack is pending durin..." (Closed)

Created:
7 years, 6 months ago by jamesr
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 204014 "Don't track whether a resize ack is pending durin..." > Don't track whether a resize ack is pending during layout tests > > Unlike normal operation, in layout tests the renderer can request a synchronous > change of its size. The renderer and the browser therefore often run out of > sync. However, it's important that the renderer always acks a resize request > from the browser. > > Previously, I tried to track the size the browser expects the renderer to have > in the renderer, however, this turns out to not work when the compositor is in > hidpi mode. Instead of trying to fix this up somehow, just ignore whether or > not the browser is expecting resize acks during layout tests > > BUG=244369 > > Review URL: https://chromiumcodereview.appspot.com/16285005 Breaks fast/hidpi on windows TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M trunk/src/content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +1 line, -8 lines 0 comments Download
M trunk/src/content/renderer/render_widget.h View 1 chunk +6 lines, -0 lines 0 comments Download
M trunk/src/content/renderer/render_widget.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M trunk/src/content/test/layout_browsertest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/content/test/layouttest_support.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
7 years, 6 months ago (2013-06-04 20:56:32 UTC) #1
jamesr
7 years, 6 months ago (2013-06-04 20:57:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r204038.

Powered by Google App Engine
This is Rietveld 408576698