Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1632523002: `<link rel=preload>` with no `as` should be subject to connect-src (Closed)

Created:
4 years, 11 months ago by Yoav Weiss
Modified:
4 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, mkwst+watchlist-csp_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

`<link rel=preload>` with no `as` should be subject to connect-src This CL aligns the implementation with the preload spec, so that fetches triggered by link preload that has no `as` type, are subject to the connect-src directive. BUG=580758 Committed: https://crrev.com/33d50063a357635a3dbe9c4c880f39f2838fe0d8 Cr-Commit-Position: refs/heads/master@{#371491}

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Messages

Total messages: 16 (7 generated)
Yoav Weiss
Hey Mike :) Can you take a look?
4 years, 11 months ago (2016-01-25 10:27:50 UTC) #2
Yoav Weiss
On 2016/01/25 10:27:50, Yoav Weiss wrote: > Hey Mike :) > Can you take a ...
4 years, 11 months ago (2016-01-25 12:58:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632523002/20001
4 years, 11 months ago (2016-01-25 14:36:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 18:21:06 UTC) #8
Mike West
LGTM. Do I need to make changes to CSP based on this? Or does the ...
4 years, 11 months ago (2016-01-26 09:55:42 UTC) #9
Yoav Weiss
On 2016/01/26 09:55:42, Mike West wrote: > LGTM. Do I need to make changes to ...
4 years, 11 months ago (2016-01-26 10:03:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632523002/20001
4 years, 11 months ago (2016-01-26 11:25:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 11:30:14 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 11:31:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33d50063a357635a3dbe9c4c880f39f2838fe0d8
Cr-Commit-Position: refs/heads/master@{#371491}

Powered by Google App Engine
This is Rietveld 408576698