Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1632513002: Add a fragment change exception to history API's unique origin restrictions. (Closed)

Created:
4 years, 11 months ago by Mike West
Modified:
4 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a fragment change exception to history API's unique origin restrictions. Things like jQuery Mobile and Apple's Keynote use hash changes via 'replaceState' for routing. Treating 'file:' URLs as unique breaks them. We can fairly safely carve out an exception for changes that only effect the URL's fragment identifier ('#...'), and doing so will prevent breakage. BUG=528681 R=jochen@chromium.org Committed: https://crrev.com/f5cdfde9135883c6cd83c81436ebe4888c432b8b Cr-Commit-Position: refs/heads/master@{#371238}

Patch Set 1 #

Patch Set 2 : Test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/navigation/pushstate-at-unique-origin-denied.html View 1 1 chunk +10 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/navigation/pushstate-whitelisted-at-unique-origin-denied.html View 1 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.h View 3 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/core/frame/HistoryTest.cpp View 1 chunk +116 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
Mind taking a look, Jochen?
4 years, 11 months ago (2016-01-25 09:44:09 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-25 09:46:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632513002/20001
4 years, 11 months ago (2016-01-25 12:54:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 14:30:53 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 14:32:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5cdfde9135883c6cd83c81436ebe4888c432b8b
Cr-Commit-Position: refs/heads/master@{#371238}

Powered by Google App Engine
This is Rietveld 408576698