Move thread_pool.h into utils so it can be shared by more than one example.

Move thread_pool.h into utils so it can be shared by more than one example.
BUG=none
TEST=voronoi demo
R=binji@chromium.org, noelallen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204998

[binji, 2013-06-04 23:30:28]

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/example...
File native_client_sdk/src/examples/Makefile (right):

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/example...
native_client_sdk/src/examples/Makefile:11: [[for project in projects:]] \
not necessary: this is a template Makefile. Everything between [[ and ]] is
interpreted by python, but not written to the output file.

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_io/library.dsc (left):

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/library.dsc:79: "auto_lock.h",
what .dsc copies these files now? did you forget to upload it?

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/utils/thread_pool.h (right):

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/utils/thread_pool.h:55:
ThreadPool::ThreadPool(int num_threads)
should this all be inline...?

[nfullagar1, 2013-06-04 23:47:09]

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/example...
File native_client_sdk/src/examples/Makefile (right):

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/example...
native_client_sdk/src/examples/Makefile:11: [[for project in projects:]] \
On 2013/06/04 23:30:28, binji wrote:
> not necessary: this is a template Makefile. Everything between [[ and ]] is
> interpreted by python, but not written to the output file
removed

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_io/library.dsc (left):

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/library.dsc:79: "auto_lock.h",
On 2013/06/04 23:30:28, binji wrote:
> what .dsc copies these files now? did you forget to upload it?

Missed the svn add!  should be there now

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/utils/thread_pool.h (right):

https://codereview.chromium.org/16325024/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/utils/thread_pool.h:55:
ThreadPool::ThreadPool(int num_threads)
On 2013/06/04 23:30:28, binji wrote:
> should this all be inline...?
I'm on the fence - it's not that much code (compare with STL templates...)  vs.
making utils into a full blown library.  Was hoping to hold off on that for this
round...

[binji, 2013-06-05 00:01:09]

lgtm

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/nacl_io/library.dsc (right):

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/nacl_io/library.dsc:6: '../utils'
remove this line

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/utils/library.dsc (right):

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/utils/library.dsc:5: 'pepper'
not needed

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/utils/library.dsc:7: 'TARGETS': [
remove TARGETS

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/utils/thread_pool.h (right):

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/utils/thread_pool.h:48: pthread_mutex_t mutex_;
used?

[nfullagar1, 2013-06-05 00:11:45]

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/nacl_io/library.dsc (right):

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/nacl_io/library.dsc:6: '../utils'
On 2013/06/05 00:01:09, binji wrote:
> remove this line

Done.

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/utils/library.dsc (right):

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/utils/library.dsc:5: 'pepper'
On 2013/06/05 00:01:09, binji wrote:
> not needed

Done.

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/utils/library.dsc:7: 'TARGETS': [
On 2013/06/05 00:01:09, binji wrote:
> remove TARGETS
this was needed to make the python scripts pass.

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
File native_client_sdk/src/libraries/utils/thread_pool.h (right):

https://codereview.chromium.org/16325024/diff/7004/native_client_sdk/src/libr...
native_client_sdk/src/libraries/utils/thread_pool.h:48: pthread_mutex_t mutex_;
On 2013/06/05 00:01:09, binji wrote:
> used?
removed

[nfullagar1, 2013-06-05 01:03:29]

after in-cube discussion, moving utils/ to sdk_util/
suggest holding off further reviewing until this is uploaded.

[nfullagar1, 2013-06-05 23:30:53]

move is complete... ptal

[noelallen1, 2013-06-05 23:42:43]

lgtm

[nfullagar1, 2013-06-06 18:09:32]

https://codereview.chromium.org/16325024/diff/40001/native_client_sdk/src/bui...
File native_client_sdk/src/build_tools/sdk_files.list (right):

https://codereview.chromium.org/16325024/diff/40001/native_client_sdk/src/bui...
native_client_sdk/src/build_tools/sdk_files.list:877: src/sdk_util/Makefile
On 2013/06/06 17:39:36, binji wrote:
> make.bat for windows
thx, done

[bradn, 2013-06-06 23:24:22]

Uh, maybe try it as svn cp / svn rm? It might not grok the move.

[nfullagar1, 2013-06-08 00:46:07]

Committed patchset #25 manually as r204998 (presubmit successful).