Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 16325006: Fix broken include path for directwrite backend (Closed)

Created:
7 years, 6 months ago by djsollen
Modified:
7 years, 6 months ago
Reviewers:
borenet, Zach Reizner
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix broken include path for directwrite backend R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=9400

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/ports.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
djsollen
7 years, 6 months ago (2013-06-03 14:04:02 UTC) #1
borenet
https://codereview.chromium.org/16325006/diff/1/gyp/ports.gyp File gyp/ports.gyp (right): https://codereview.chromium.org/16325006/diff/1/gyp/ports.gyp#newcode10 gyp/ports.gyp:10: 'utils.gyp:utils', Does this give us '../src/utils' as an include ...
7 years, 6 months ago (2013-06-03 14:13:49 UTC) #2
borenet
LGTM at patch set 2.
7 years, 6 months ago (2013-06-03 14:44:09 UTC) #3
djsollen
7 years, 6 months ago (2013-06-03 14:44:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r9400.

Powered by Google App Engine
This is Rietveld 408576698