Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 16325005: Remove the Media Query "forward compatibly syntax" support in alignment with HTML5 spec (Closed)

Created:
7 years, 6 months ago by kenneth.r.christiansen
Modified:
7 years, 6 months ago
Reviewers:
apavlov1, apavlov, rune
CC:
blink-reviews, kenneth.christiansen, gavinp+prerender_chromium.org, eae+blinkwatch, feature-media-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, vcarbune.chromium
Visibility:
Public.

Description

Remove the Media Query "forward compatibly syntax" support in alignment with HTML5 spec Media queries, as described in the Media Queries Level 3 specification, build on the mechanism outlined in HTML4. The syntax of media queries fit into the media type syntax reserved in HTML4. The media attribute of HTML4 also exists in XHTML and generic XML. The same syntax can also be used inside in the ‘@media’ and ‘@import’ rules of CSS. However, the parsing rules for media queries are incompatible with those of HTML4 so that they are consistent with those of media queries used in CSS. HTML5 references the Media Queries specification directly and thus updates the rules for HTML. This change is in alignment with Presto and Gecko behavior. R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151772

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -143 lines) Patch
M LayoutTests/fast/media/media-descriptor-syntax-01.html View 1 chunk +5 lines, -4 lines 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-01-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-02.html View 1 chunk +5 lines, -6 lines 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-02-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-03.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-03-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-04.html View 1 chunk +6 lines, -4 lines 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-04-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-05.html View 1 chunk +5 lines, -4 lines 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-05-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-06.html View 1 chunk +5 lines, -4 lines 0 comments Download
M LayoutTests/fast/media/media-descriptor-syntax-06-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/mq-invalid-syntax-01.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/media/mq-invalid-syntax-01-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/mq-invalid-syntax-02.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/media/mq-invalid-syntax-02-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/mq-invalid-syntax-03.html View 2 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/fast/media/mq-invalid-syntax-05.html View 2 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/fast/media/mq-invalid-syntax-05-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/mq-js-media-except-03.html View 1 chunk +15 lines, -13 lines 0 comments Download
M LayoutTests/fast/media/mq-js-media-except-03-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/mq-js-media-forward-syntax.html View 1 chunk +7 lines, -11 lines 0 comments Download
M LayoutTests/fast/media/mq-js-media-forward-syntax-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/mq-js-stylesheet-media-01.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/media/mq-js-stylesheet-media-01-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/media/mq-js-stylesheet-media-02.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/mq-js-stylesheet-media-02-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaList.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 3 chunks +12 lines, -42 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
Source/core/dom/StyleElement.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kenneth.r.christiansen
7 years, 6 months ago (2013-06-03 14:08:42 UTC) #1
rune
Rubber stamp. I did not look much at the modified test-cases.
7 years, 6 months ago (2013-06-03 14:38:43 UTC) #2
apavlov
https://codereview.chromium.org/16325005/diff/1/Source/core/css/MediaList.cpp File Source/core/css/MediaList.cpp (right): https://codereview.chromium.org/16325005/diff/1/Source/core/css/MediaList.cpp#newcode44 Source/core/css/MediaList.cpp:44: * and generic XML. The same syntax can also ...
7 years, 6 months ago (2013-06-04 14:17:47 UTC) #3
apavlov
lgtm with comments
7 years, 6 months ago (2013-06-04 14:20:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/16325005/7001
7 years, 6 months ago (2013-06-04 16:47:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=11418
7 years, 6 months ago (2013-06-04 17:39:54 UTC) #6
kenneth.r.christiansen
7 years, 6 months ago (2013-06-04 19:59:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r151772 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698