Precisely account for required buttons in a radio group.

Precisely account for required buttons in a radio group.

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=

Committed: https://crrev.com/41bffb130f01d585117db7569e7fb07429f46461
Cr-Commit-Position: refs/heads/master@{#371476}

[sof, 2016-01-25 09:19:23]

sigbjornf@opera.com changed reviewers:
+ keishi@chromium.org, tkent@chromium.org

[sof, 2016-01-25 09:19:24]

please take a look.

The m_requiredCount assert in RadioButtonGroup::remove() has been flakily
triggering for a while, attempt at fixing it.

If you go looking on the dbg bots, you'll find it there e.g.
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...
(not that breakpad is being too helpful with linux stack traces; has been broken
for a very long time.)

[keishi, 2016-01-25 12:21:35]

On 2016/01/25 09:19:24, sof wrote:
> please take a look.
> 
> The m_requiredCount assert in RadioButtonGroup::remove() has been flakily
> triggering for a while, attempt at fixing it.
> 
> If you go looking on the dbg bots, you'll find it there e.g.
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...
> (not that breakpad is being too helpful with linux stack traces; has been
broken
> for a very long time.)

LGTM

I see. When parsing RadioButtonGroup::add is called and isRequired is already
true but requiredAttributeChanged also gets called.

[sof, 2016-01-25 20:56:05]

On 2016/01/25 12:21:35, keishi wrote:
> On 2016/01/25 09:19:24, sof wrote:
> > please take a look.
> > 
> > The m_requiredCount assert in RadioButtonGroup::remove() has been flakily
> > triggering for a while, attempt at fixing it.
> > 
> > If you go looking on the dbg bots, you'll find it there e.g.
> >
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__db...
> > (not that breakpad is being too helpful with linux stack traces; has been
> broken
> > for a very long time.)
> 
> LGTM
> 
> I see. When parsing RadioButtonGroup::add is called and isRequired is already
> true but requiredAttributeChanged also gets called.

Yes; to handle the different ways/states a button might be added to the radio
button group, I didn't see way around changing the representation of m_members
like this.

[tkent, 2016-01-25 23:56:07]

lgtm

[sof, 2016-01-26 07:23:43]

Description was changed from

==========
Precisely account for required buttons in a radio group.

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=
BUG=
==========

to

==========
Precisely account for required buttons in a radio group.

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=
==========

[sof, 2016-01-26 07:23:57]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-01-26 07:24:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1632493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1632493002/20001

[commit-bot: I haz the power, 2016-01-26 08:16:34]

Description was changed from

==========
Precisely account for required buttons in a radio group.

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=
==========

to

==========
Precisely account for required buttons in a radio group.

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=
==========

[commit-bot: I haz the power, 2016-01-26 08:16:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 08:17:50]

Description was changed from

==========
Precisely account for required buttons in a radio group.

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=
==========

to

==========
Precisely account for required buttons in a radio group.

As part of processing the name attribute for a radio button, it is
added to the current radio button group. For buttons that are
additionally "required", that leads to double accounting for the
group's count of such required buttons, as the radio button group
doesn't keep track what has been registered as "required" already
or not.

Address by having the button group track the registered "required"
state of its members/buttons.

R=keishi,tkent
BUG=

Committed: https://crrev.com/41bffb130f01d585117db7569e7fb07429f46461
Cr-Commit-Position: refs/heads/master@{#371476}
==========

[commit-bot: I haz the power, 2016-01-26 08:17:50]

Patchset 2 (id:??) landed as
https://crrev.com/41bffb130f01d585117db7569e7fb07429f46461
Cr-Commit-Position: refs/heads/master@{#371476}