Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1632453002: X87: [interpreter] Fix return address when entering exception handler. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] Fix return address when entering exception handler. port ca51c204e1ab1519e2c623a74fad117577c37732(r33463) original commit message: This fixes the broken return address when the exception handler within interpreted bytecode is being entered via stack unwinding. The address in question will never actually be taken, but our stack walker uses this address to determine whether a frame is interpreted. BUG= Committed: https://crrev.com/22445627e8bd39a550ed0ad91066849326cccc97 Cr-Commit-Position: refs/heads/master@{#33482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-25 06:39:36 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-25 07:15:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632453002/1
4 years, 11 months ago (2016-01-25 07:19:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 07:38:41 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 07:38:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22445627e8bd39a550ed0ad91066849326cccc97
Cr-Commit-Position: refs/heads/master@{#33482}

Powered by Google App Engine
This is Rietveld 408576698