[MD settings] download mocks changes; added disable option for google drive

[MD settings] download mocks changes; added disable option for google drive

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
Committed: https://crrev.com/ce82d23ab4f830dfe655854e310baf110ef36b7c
Cr-Commit-Position: refs/heads/master@{#372001}

[dschuyler, 2016-01-27 01:45:11]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-01-27 19:30:18]

https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_resources.grd (right):

https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_resources.grd:230:
allowexternalscript="true" />
Remind me why exactly we need each of these?

[Dan Beam, 2016-01-27 19:31:37]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-01-27 19:31:37]

https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_resources.grd (right):

https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_resources.grd:230:
allowexternalscript="true" />
On 2016/01/27 19:30:18, stevenjb wrote:
> Remind me why exactly we need each of these?

flatten: grit
allowexternalscript: no idea, but it probably matters

[stevenjb, 2016-01-27 19:39:08]

Specifically, what changes in this CL require these?


On Wed, Jan 27, 2016 at 11:31 AM, <dbeam@chromium.org> wrote:

>
>
https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/settings_resources.grd (right):
>
https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/settings_resources.grd:230
<https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...>:
> allowexternalscript="true" />
> On 2016/01/27 19:30:18, stevenjb wrote:
> > Remind me why exactly we need each of these?
>
> flatten: grit
> allowexternalscript: no idea, but it probably matters
> https://codereview.chromium.org/1632403003/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dschuyler, 2016-01-27 19:53:32]

On 2016/01/27 19:39:08, stevenjb wrote:
> Specifically, what changes in this CL require these?
> 
> 
> On Wed, Jan 27, 2016 at 11:31 AM, <mailto:dbeam@chromium.org> wrote:
> 
> >
> >
>
https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
> > File chrome/browser/resources/settings/settings_resources.grd (right):
> >
>
https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...
> > chrome/browser/resources/settings/settings_resources.grd:230
>
<https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...>:
> > allowexternalscript="true" />
> > On 2016/01/27 19:30:18, stevenjb wrote:
> > > Remind me why exactly we need each of these?
> >
> > flatten: grit
> > allowexternalscript: no idea, but it probably matters
> > https://codereview.chromium.org/1632403003/
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

On the flatten and allowexternalscript:
I was trying to get the <if expr="chromeos"> in downloads_page.html
to properly strip the code (when expr was false).
I tried only flattenhtml at first, and that didn't work for me in my
test.  Adding both (as other pages do) makes <if expr="chromeos">
work as expected.  Both seem related to grit:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/grit/grit/no...

[stevenjb, 2016-01-27 19:54:32]

Ahh, OK, got it. Thanks.
LGTM

On Wed, Jan 27, 2016 at 11:53 AM, <dschuyler@chromium.org> wrote:

> On 2016/01/27 19:39:08, stevenjb wrote:
> > Specifically, what changes in this CL require these?
> >
> >
> > On Wed, Jan 27, 2016 at 11:31 AM, <mailto:dbeam@chromium.org> wrote:
> >
> > >
> > >
>
>https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resources/settings/settings_resources.grd
> > > File chrome/browser/resources/settings/settings_resources.grd (right):
> > >
>
>https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resources/settings/settings_resources.grd#newcode230
> > > chrome/browser/resources/settings/settings_resources.grd:230
> >
>
<https://codereview.chromium.org/1632403003/diff/20001/chrome/browser/resource...>:
> > > allowexternalscript="true" />
> > > On 2016/01/27 19:30:18, stevenjb wrote:
> > > > Remind me why exactly we need each of these?
> > >
> > > flatten: grit
> > > allowexternalscript: no idea, but it probably matters
> > > https://codereview.chromium.org/1632403003/
> > >
> > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "Chromium-reviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
>
> On the flatten and allowexternalscript:
> I was trying to get the <if expr="chromeos"> in downloads_page.html
> to properly strip the code (when expr was false).
> I tried only flattenhtml at first, and that didn't work for me in my
> test.  Adding both (as other pages do) makes <if expr="chromeos">
> work as expected.  Both seem related to
grit:https://code.google.com/p/chromium/codesearch#chromium/src/tools/grit/grit/node/include.py&q=allowexternalscript&sq=package:chromium&type=cs&l=87
> https://codereview.chromium.org/1632403003/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[stevenjb, 2016-01-27 19:54:59]

lgtm

[Dan Beam, 2016-01-28 01:28:27]

Description was changed from

==========
[MD settings] download mocks changes; added disable option for google dirve

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
==========

to

==========
[MD settings] download mocks changes; added disable option for google dirve

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
==========

[Dan Beam, 2016-01-28 01:28:27]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[dschuyler, 2016-01-28 01:57:50]

Description was changed from

==========
[MD settings] download mocks changes; added disable option for google dirve

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
==========

to

==========
[MD settings] download mocks changes; added disable option for google drive

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
==========

[dschuyler, 2016-01-28 01:57:57]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-01-28 01:59:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1632403003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1632403003/20001

[commit-bot: I haz the power, 2016-01-28 04:00:38]

Description was changed from

==========
[MD settings] download mocks changes; added disable option for google drive

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
==========

to

==========
[MD settings] download mocks changes; added disable option for google drive

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
==========

[commit-bot: I haz the power, 2016-01-28 04:00:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 04:01:39]

Description was changed from

==========
[MD settings] download mocks changes; added disable option for google drive

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847
==========

to

==========
[MD settings] download mocks changes; added disable option for google drive

This CL changes the Downloads settings to more closely match
the mocks.  An option to disconnect Google Drive account has
been added for chromeos.

BUG=546847

Committed: https://crrev.com/ce82d23ab4f830dfe655854e310baf110ef36b7c
Cr-Commit-Position: refs/heads/master@{#372001}
==========

[commit-bot: I haz the power, 2016-01-28 04:01:40]

Patchset 2 (id:??) landed as
https://crrev.com/ce82d23ab4f830dfe655854e310baf110ef36b7c
Cr-Commit-Position: refs/heads/master@{#372001}