Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 16324005: Fix dartbug.com/11010. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove newline. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/language/regress_11010_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of resolution; 5 part of resolution;
6 6
7 abstract class TreeElements { 7 abstract class TreeElements {
8 Element get currentElement; 8 Element get currentElement;
9 Set<Node> get superUses; 9 Set<Node> get superUses;
10 10
(...skipping 2276 matching lines...) Expand 10 before | Expand all | Expand 10 after
2287 } 2287 }
2288 2288
2289 // If the selector is null, it means that we will not be generating 2289 // If the selector is null, it means that we will not be generating
2290 // code for this as a send. 2290 // code for this as a send.
2291 Selector selector = mapping.getSelector(node); 2291 Selector selector = mapping.getSelector(node);
2292 if (selector == null) return; 2292 if (selector == null) return;
2293 2293
2294 if (node.isCall) { 2294 if (node.isCall) {
2295 if (Elements.isUnresolved(target) || 2295 if (Elements.isUnresolved(target) ||
2296 target.isGetter() || 2296 target.isGetter() ||
2297 target.isField() ||
2297 Elements.isClosureSend(node, target)) { 2298 Elements.isClosureSend(node, target)) {
2298 // If we don't know what we're calling or if we are calling a getter, 2299 // If we don't know what we're calling or if we are calling a getter,
2299 // we need to register that fact that we may be calling a closure 2300 // we need to register that fact that we may be calling a closure
2300 // with the same arguments. 2301 // with the same arguments.
2301 Selector call = new Selector.callClosureFrom(selector); 2302 Selector call = new Selector.callClosureFrom(selector);
2302 world.registerDynamicInvocation(call.name, call); 2303 world.registerDynamicInvocation(call.name, call);
2303 } else if (target.impliesType()) { 2304 } else if (target.impliesType()) {
2304 // We call 'call()' on a Type instance returned from the reference to a 2305 // We call 'call()' on a Type instance returned from the reference to a
2305 // class or typedef literal. We do not need to register this call as a 2306 // class or typedef literal. We do not need to register this call as a
2306 // dynamic invocation, because we statically know what the target is. 2307 // dynamic invocation, because we statically know what the target is.
(...skipping 1719 matching lines...) Expand 10 before | Expand all | Expand 10 after
4026 return e; 4027 return e;
4027 } 4028 }
4028 4029
4029 /// Assumed to be called by [resolveRedirectingFactory]. 4030 /// Assumed to be called by [resolveRedirectingFactory].
4030 Element visitReturn(Return node) { 4031 Element visitReturn(Return node) {
4031 Node expression = node.expression; 4032 Node expression = node.expression;
4032 return finishConstructorReference(visit(expression), 4033 return finishConstructorReference(visit(expression),
4033 expression, expression); 4034 expression, expression);
4034 } 4035 }
4035 } 4036 }
OLDNEW
« no previous file with comments | « no previous file | tests/language/regress_11010_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698