Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1632393002: [Chromecast] Resample all audio below 32000 Hz. (Closed)

Created:
4 years, 10 months ago by jyw
Modified:
4 years, 10 months ago
Reviewers:
wzhong, halliwell, kmackay
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Resample all audio below 32000 Hz. Workaround to fix playback of some 22050 Hz sample rate TuneIn radio stations that do not play through optical out on some AVRs. In particular, Denon receivers do not support 22050 Hz optical out playback. The audio is resampled to either the current mixer output sample rate (if valid) and kFallbackSampleRate (48000 Hz) otherwise. BUG=internal b/26385501 TEST=fling 22050 Hz sample rate WAV file 1) to a freshly booted device, and 2) to a device that was playing a 64 kHz sample rate WAV file. Committed: https://crrev.com/1e12ce9f124828d724656a8e113213acc39aa9cc Cr-Commit-Position: refs/heads/master@{#371694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc View 6 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jyw
4 years, 10 months ago (2016-01-27 01:20:45 UTC) #3
kmackay
lgtm
4 years, 10 months ago (2016-01-27 01:52:55 UTC) #4
wzhong
lgtm
4 years, 10 months ago (2016-01-27 01:57:41 UTC) #5
halliwell
On 2016/01/27 01:57:41, wzhong wrote: > lgtm lgtm
4 years, 10 months ago (2016-01-27 02:14:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632393002/1
4 years, 10 months ago (2016-01-27 02:16:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 02:42:53 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 02:43:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e12ce9f124828d724656a8e113213acc39aa9cc
Cr-Commit-Position: refs/heads/master@{#371694}

Powered by Google App Engine
This is Rietveld 408576698