Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1632363002: Get v8 builds to use up-to-date VS toolchains (Closed)

Created:
4 years, 11 months ago by brucedawson
Modified:
4 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, scottmg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get v8 builds to use up-to-date VS toolchains The VS 2013 toolchain used by v8 is ~two months out of date. The Chromium toolchain was updated in October to include the Windows 10 SDK. Using a different toolchain in v8 leads to the possibility of odd incompatibilities, and means that switching between Chromium and v8 requires a time-consuming reinstallation of the toolchain. The VS 2013 toolchain was updated by crrev.com/1502563003. The VS 2015 toolchain used by v8 is also out of date. It is the wrong compiler version (RTM instead of Update 1), the wrong SDK version, and it is missing files such as the UCRT installers. LOG=N BUG=440500, 491424 Committed: https://crrev.com/aa354d3f6ff1a8b5db9958cf54d3464fea023397 Cr-Commit-Position: refs/heads/master@{#33560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/vs_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brucedawson
4 years, 11 months ago (2016-01-26 22:14:03 UTC) #2
Michael Achenbach
lgtm I'd be nice if this file lived in the buildtools repo (for both chromium ...
4 years, 11 months ago (2016-01-27 08:16:20 UTC) #3
brucedawson
On 2016/01/27 08:16:20, Michael Achenbach wrote: > lgtm > > I'd be nice if this ...
4 years, 11 months ago (2016-01-27 17:53:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632363002/1
4 years, 11 months ago (2016-01-27 17:54:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 18:17:11 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 18:18:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa354d3f6ff1a8b5db9958cf54d3464fea023397
Cr-Commit-Position: refs/heads/master@{#33560}

Powered by Google App Engine
This is Rietveld 408576698