Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1632343003: Revert of [Android] Switch chromium bots on chromium.android to gn. (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, ghost stip (do not use), agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Switch chromium bots on chromium.android to gn. (patchset #1 id:1 of https://codereview.chromium.org/1636003003/ ) Reason for revert: broken w/ ninja: Entering directory `/b/build/slave/android_build/build/src/out/Debug' ninja: error: unknown target 'android_builder_tests' or In file included from ../../content/gpu/in_process_gpu_thread.cc:10:0: ../../content/gpu/gpu_child_thread.h:24:50: fatal error: content/common/process_control.mojom.h: No such file or directory #include "content/common/process_control.mojom.h" Original issue's description: > [Android] Switch chromium bots on chromium.android to gn. > > This still does not include cronet or webview. > > BUG=580129 > > Committed: https://crrev.com/1f63a1d9804b3c25dd896b52b3b3baf3700293fe > Cr-Commit-Position: refs/heads/master@{#371641} TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=580129 Committed: https://crrev.com/b4e418c3b91110b54b0429a38bbf323fc5cb87f9 Cr-Commit-Position: refs/heads/master@{#371679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbudorick
Created Revert of [Android] Switch chromium bots on chromium.android to gn.
4 years, 11 months ago (2016-01-27 01:24:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632343003/1
4 years, 11 months ago (2016-01-27 01:26:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632343003/1
4 years, 11 months ago (2016-01-27 01:33:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 01:36:11 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4e418c3b91110b54b0429a38bbf323fc5cb87f9 Cr-Commit-Position: refs/heads/master@{#371679}
4 years, 11 months ago (2016-01-27 01:37:23 UTC) #7
Dirk Pranke
lgtm
4 years, 11 months ago (2016-01-27 03:59:41 UTC) #8
jbudorick
4 years, 11 months ago (2016-01-27 05:17:06 UTC) #9
Message was sent while issue was closed.
On 2016/01/27 03:59:41, Dirk Pranke wrote:
> lgtm

to close the loop here: I have to make a couple more recipe changes, but I think
everything on the chromium side is ok.

Powered by Google App Engine
This is Rietveld 408576698