|
|
Created:
6 years, 10 months ago by David Tseng Modified:
6 years, 10 months ago Reviewers:
Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionFix accessibility_unittests.
BUG=343580
TBR=avi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251224
Patch Set 1 #
Messages
Total messages: 13 (0 generated)
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/163233005/1
I'm curious why this didn't fail on other bots.
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by dtseng@chromium.org
On Thu, Feb 13, 2014 at 12:58 PM, <avi@chromium.org> wrote: > I'm curious why this didn't fail on other bots. > > Do these tests get run on other platforms (I'm guessing no)? They should fail everywhere. > https://codereview.chromium.org/163233005/ > > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-reviews+unsubscribe@chromium.org. > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/163233005/1
On 2014/02/13 22:38:17, David Tseng wrote: > On Thu, Feb 13, 2014 at 12:58 PM, <mailto:avi@chromium.org> wrote: > > > I'm curious why this didn't fail on other bots. > > > > Do these tests get run on other platforms (I'm guessing no)? They should > fail everywhere. Where _do_ these tests run? If they should have been failing on every bot but were only failing on mine, you need to look into what the heck is happening.
avi@chromium.org writes: > On 2014/02/13 22:38:17, David Tseng wrote: > > On Thu, Feb 13, 2014 at 12:58 PM, <mailto:avi@chromium.org> wrote: > > > > I'm curious why this didn't fail on other bots. > > > > > > Do these tests get run on other platforms (I'm guessing no)? They should > > fail everywhere. > > Where _do_ these tests run? If they should have been failing on every bot > but > were only failing on mine, you need to look into what the heck is happening. I see this bug crbug.com/322537 is still open, don't know if there's still something to be done for that. //Peter > https://codereview.chromium.org/163233005/ -- To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
FYI. I am seeing this test fail on _some_ try bots (i.e. linux_chromeos). Peter, thanks for the bug. I'll ping it with the list of non-failing bots. On Thu, Feb 13, 2014 at 2:58 PM, <plundblad@chromium.org> wrote: > avi@chromium.org writes: > > On 2014/02/13 22:38:17, David Tseng wrote: > > > On Thu, Feb 13, 2014 at 12:58 PM, <mailto:avi@chromium.org> wrote: > > > > > > I'm curious why this didn't fail on other bots. > > > > > > > > Do these tests get run on other platforms (I'm guessing no)? They > should > > > fail everywhere. > > > > Where _do_ these tests run? If they should have been failing on every bot > > but > > were only failing on mine, you need to look into what the heck is > happening. > > I see this bug crbug.com/322537 is still open, don't know if there's still > something to be done for that. > > //Peter > > https://codereview.chromium.org/163233005/ > > -- > > To unsubscribe from this group and stop receiving emails from it, send an > email to chromium-reviews+unsubscribe@chromium.org. > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Committed patchset #1 manually as r251224 (presubmit successful). |