Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1632313002: add legacy eval cubic (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add legacy eval cubic An upcoming CL in Skia uses SIMD instructions to compute the coefficients for cubic and quadratic polynomials. This introduces some minor differences. Add a legacy flag to permit cubic eval() to work as it did in the past until the appropriate layout tests can be rebaselined. R=fmalita@chromium.org Committed: https://crrev.com/8fe699c7f4a45aef051a9528972e9b637ab5ebb5 Cr-Commit-Position: refs/heads/master@{#371606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caryclark
4 years, 11 months ago (2016-01-26 20:46:20 UTC) #1
f(malita)
lgtm
4 years, 11 months ago (2016-01-26 20:47:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632313002/1
4 years, 11 months ago (2016-01-26 20:48:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 21:40:21 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:41:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fe699c7f4a45aef051a9528972e9b637ab5ebb5
Cr-Commit-Position: refs/heads/master@{#371606}

Powered by Google App Engine
This is Rietveld 408576698