Treat yield expressions as an AssignmentPattern error

Treat yield expressions as an AssignmentPattern error

They were already treated as a BindingPattern error; this patch simply
replaces that call with one marking them as both a binding and assignment
error, and adds parsing tests for both cases.

BUG=v8:4707
LOG=n

Committed: https://crrev.com/b874e3d521e11baa77c36014a999ed7c33ec9a41
Cr-Commit-Position: refs/heads/master@{#33528}

[adamk, 2016-01-26 19:16:56]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[rossberg, 2016-01-26 19:33:10]

lgtm

https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:2421: "({a: yield 24} = {a: 42});",
Maybe add cases for {[yield]: x} = {...}, just to be sure.

[adamk, 2016-01-26 19:39:57]

https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:2421: "({a: yield 24} = {a: 42});",
On 2016/01/26 19:33:09, rossberg wrote:
> Maybe add cases for {[yield]: x} = {...}, just to be sure.

Do you mean for valid parsing of {[yield]: x} (that's a computed property name
as part of a binding pattern)? Or did you mean {x: [yield]}?

[rossberg, 2016-01-26 19:56:26]

https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:2421: "({a: yield 24} = {a: 42});",
On 2016/01/26 19:39:57, adamk wrote:
> On 2016/01/26 19:33:09, rossberg wrote:
> > Maybe add cases for {[yield]: x} = {...}, just to be sure.
> 
> Do you mean for valid parsing of {[yield]: x} (that's a computed property name
> as part of a binding pattern)? Or did you mean {x: [yield]}?

The former.

[adamk, 2016-01-26 20:23:49]

On 2016/01/26 19:56:26, rossberg wrote:
> https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc
> File test/cctest/test-parsing.cc (right):
> 
>
https://codereview.chromium.org/1632303002/diff/1/test/cctest/test-parsing.cc...
> test/cctest/test-parsing.cc:2421: "({a: yield 24} = {a: 42});",
> On 2016/01/26 19:39:57, adamk wrote:
> > On 2016/01/26 19:33:09, rossberg wrote:
> > > Maybe add cases for {[yield]: x} = {...}, just to be sure.
> > 
> > Do you mean for valid parsing of {[yield]: x} (that's a computed property
name
> > as part of a binding pattern)? Or did you mean {x: [yield]}?
> 
> The former.

Done

[adamk, 2016-01-26 20:23:54]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-01-26 20:23:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1632303002/#ps20001
(title: "Added test")

[commit-bot: I haz the power, 2016-01-26 20:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1632303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1632303002/20001

[commit-bot: I haz the power, 2016-01-26 21:15:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 21:16:04]

Description was changed from

==========
Treat yield expressions as an AssignmentPattern error

They were already treated as a BindingPattern error; this patch simply
replaces that call with one marking them as both a binding and assignment
error, and adds parsing tests for both cases.

BUG=v8:4707
LOG=n
==========

to

==========
Treat yield expressions as an AssignmentPattern error

They were already treated as a BindingPattern error; this patch simply
replaces that call with one marking them as both a binding and assignment
error, and adds parsing tests for both cases.

BUG=v8:4707
LOG=n

Committed: https://crrev.com/b874e3d521e11baa77c36014a999ed7c33ec9a41
Cr-Commit-Position: refs/heads/master@{#33528}
==========

[commit-bot: I haz the power, 2016-01-26 21:16:05]

Patchset 2 (id:??) landed as
https://crrev.com/b874e3d521e11baa77c36014a999ed7c33ec9a41
Cr-Commit-Position: refs/heads/master@{#33528}