Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1632273002: Add an whitelist of bindings/ include (Closed)

Created:
4 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an whitelist of bindings/ include This will avoid new dependencies and helps with keeping track of the refactoring. R=pfeldman@chromium.org BUG= NOPRESUBMIT=true Committed: https://crrev.com/50b90332c348e387afaf06b296b3cb46ed2d3b1e Cr-Commit-Position: refs/heads/master@{#371752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A third_party/WebKit/Source/core/inspector/v8/DEPS View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jochen (gone - plz use gerrit)
4 years, 11 months ago (2016-01-26 17:52:35 UTC) #1
pfeldman
lgtm
4 years, 11 months ago (2016-01-26 18:21:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632273002/1
4 years, 11 months ago (2016-01-26 18:35:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/139140)
4 years, 11 months ago (2016-01-26 18:47:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632273002/1
4 years, 11 months ago (2016-01-27 07:21:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 07:23:09 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 07:24:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50b90332c348e387afaf06b296b3cb46ed2d3b1e
Cr-Commit-Position: refs/heads/master@{#371752}

Powered by Google App Engine
This is Rietveld 408576698