Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 1632213002: [Interpreter] Implement do expressions. (Closed)

Created:
4 years, 10 months ago by rmcilroy
Modified:
4 years, 10 months ago
Reviewers:
oth, mythria
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Implement do expressions. Implements do expressions for the Ignition. BUG=v8:4685 LOG=N Committed: https://crrev.com/04c00ee9380cc0383b6ce8effdc9666cfb620930 Cr-Commit-Position: refs/heads/master@{#33525}

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -1 line) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 1 chunk +62 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
rmcilroy
Mythri / Orion, PTAL, thanks. This passes the mjsunit/harmony/do-expressions.js tests, however all harmony tests are ...
4 years, 10 months ago (2016-01-26 13:16:14 UTC) #3
oth
lgtm.
4 years, 10 months ago (2016-01-26 14:13:35 UTC) #4
mythria
lgtm
4 years, 10 months ago (2016-01-26 15:38:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632213002/20001
4 years, 10 months ago (2016-01-26 15:38:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/520) v8_presubmit on tryserver.v8 (JOB_FAILED, ...
4 years, 10 months ago (2016-01-26 15:39:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632213002/40001
4 years, 10 months ago (2016-01-26 16:55:13 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-01-26 17:18:28 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 17:19:23 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04c00ee9380cc0383b6ce8effdc9666cfb620930
Cr-Commit-Position: refs/heads/master@{#33525}

Powered by Google App Engine
This is Rietveld 408576698