core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp - Issue 1632143002: War on #defines, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

Issue 1632143002: War on #defines, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add const. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

index edcb3cab2dbc0c6dda7a23cfc812bb7c2ea12421..d1e6687999209247baca636dcbe5d7e7a2ae4599 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp

@@ -9,10 +9,8 @@

#include "core/include/fpdfapi/fpdf_page.h"

#include "core/include/fpdfapi/fpdf_pageobj.h"

-CPDF_ImageObject::CPDF_ImageObject() {

- m_pImage = NULL;

- m_Type = PDFPAGE_IMAGE;

+CPDF_ImageObject::CPDF_ImageObject()

+ : CPDF_PageObject(IMAGE), m_pImage(nullptr) {}

CPDF_ImageObject::~CPDF_ImageObject() {

if (!m_pImage) {

return;