Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1632133007: The missing value default for <area shape> is 'rect' (Closed)

Created:
4 years, 11 months ago by fs
Modified:
4 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The missing value default for <area shape> is 'rect' There is no invalid value default, so the missing value default will apply in that case too. The 'Unknown' HTMLAreaElement::Shape enumeration value is no longer needed, so remove it. Also add support for the non-conforming <area shape> values: * 'circ' (alias for 'circle') * 'polygon' (alias for 'poly') * 'rectangle (alias for 'rect') Because 'rect' (and hence 'rectangle') is the same as the missing value default we don't need any explicit checks for these values. https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape BUG=578125 Committed: https://crrev.com/ca1a425acf5972e25f59ea1c63a661d3be37d680 Cr-Commit-Position: refs/heads/master@{#371731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -39 lines) Patch
D third_party/WebKit/LayoutTests/fast/html/area-shape-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.cpp View 4 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fs
4 years, 11 months ago (2016-01-26 18:27:15 UTC) #4
tkent
lgtm
4 years, 11 months ago (2016-01-27 04:45:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632133007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632133007/1
4 years, 11 months ago (2016-01-27 04:46:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 04:52:30 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 04:54:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca1a425acf5972e25f59ea1c63a661d3be37d680
Cr-Commit-Position: refs/heads/master@{#371731}

Powered by Google App Engine
This is Rietveld 408576698