Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 1632133006: [Cast,Android] Don't assume there's always a matching provider for a route (Closed)

Created:
4 years, 11 months ago by whywhat
Modified:
4 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast,Android] Don't assume there's always a matching provider for a route After https://codereview.chromium.org/1593313011 the mappings between routes and MRPs are being cleaned up. Which means that if casting is stopped from the browser UI while the page tried to send a message over, Chrome will crash. BUG=None TEST=Manual Committed: https://crrev.com/eac7a1a3690a64885a70ecfe745ea0990d00efc3 Cr-Commit-Position: refs/heads/master@{#371509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
whywhat
PTaL
4 years, 11 months ago (2016-01-26 12:08:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632133006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632133006/1
4 years, 11 months ago (2016-01-26 12:09:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 12:45:42 UTC) #6
mlamouri (slow - plz ping)
lgtm
4 years, 11 months ago (2016-01-26 14:31:46 UTC) #8
Zhiqiang Zhang (Slow)
lgtm
4 years, 11 months ago (2016-01-26 14:41:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632133006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632133006/1
4 years, 11 months ago (2016-01-26 14:41:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 14:45:54 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 14:47:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eac7a1a3690a64885a70ecfe745ea0990d00efc3
Cr-Commit-Position: refs/heads/master@{#371509}

Powered by Google App Engine
This is Rietveld 408576698