Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1632133003: ipc: hide IsRecoverableError() function behind unnamed namespace (Closed)

Created:
4 years, 11 months ago by tfarina
Modified:
4 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: hide IsRecoverableError() function behind unnamed namespace This moves this free function inside an unnamed namespace (making its symbol t instead of T, and thus hidding it from global) and while at it removes its unused |err| parameter. BUG=None TEST=ipc_tests R=cpu@chromium.org Committed: https://crrev.com/5586fa791940a65642d77a7a48c0353f9ceb9d54 Cr-Commit-Position: refs/heads/master@{#371600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M ipc/unix_domain_socket_util.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
Sorry, just noticed this while reviewing the previous patch. Could you take a look? Thanks!
4 years, 11 months ago (2016-01-26 00:48:15 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
4 years, 11 months ago (2016-01-26 18:50:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632133003/1
4 years, 11 months ago (2016-01-26 20:33:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 21:23:56 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 21:29:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5586fa791940a65642d77a7a48c0353f9ceb9d54
Cr-Commit-Position: refs/heads/master@{#371600}

Powered by Google App Engine
This is Rietveld 408576698