Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1632123003: Add cross platform Bluetooth testing fixture for Windows. (Closed)

Created:
4 years, 11 months ago by gogerald1
Modified:
4 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cross platform Bluetooth testing fixture for Windows. This CL is the first step to implement GATT service in Chrome for Windows by using cross platform testing fixture. BUG=579202 Committed: https://crrev.com/512935cc3fb94185ee159d8e60c95dadc3c001e4 Cr-Commit-Position: refs/heads/master@{#371668}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -7 lines) Patch
M device/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.h View 1 chunk +1 line, -1 line 0 comments Download
A device/bluetooth/test/bluetooth_test_win.h View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A device/bluetooth/test/bluetooth_test_win.cc View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
gogerald1
Hey Vincent, PTAL.
4 years, 11 months ago (2016-01-26 19:46:10 UTC) #10
scheib
LGTM with fixes: https://codereview.chromium.org/1632123003/diff/120001/device/bluetooth/test/bluetooth_test_win.cc File device/bluetooth/test/bluetooth_test_win.cc (right): https://codereview.chromium.org/1632123003/diff/120001/device/bluetooth/test/bluetooth_test_win.cc#newcode1 device/bluetooth/test/bluetooth_test_win.cc:1: // Copyright 2015 The Chromium Authors. ...
4 years, 11 months ago (2016-01-26 20:13:47 UTC) #11
gogerald1
https://codereview.chromium.org/1632123003/diff/120001/device/bluetooth/test/bluetooth_test_win.cc File device/bluetooth/test/bluetooth_test_win.cc (right): https://codereview.chromium.org/1632123003/diff/120001/device/bluetooth/test/bluetooth_test_win.cc#newcode1 device/bluetooth/test/bluetooth_test_win.cc:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 11 months ago (2016-01-26 20:25:10 UTC) #14
scheib
https://codereview.chromium.org/1632123003/diff/120001/device/bluetooth/test/bluetooth_test_win.h File device/bluetooth/test/bluetooth_test_win.h (right): https://codereview.chromium.org/1632123003/diff/120001/device/bluetooth/test/bluetooth_test_win.h#newcode24 device/bluetooth/test/bluetooth_test_win.h:24: void SetUp() override; On 2016/01/26 20:25:10, gogerald1 wrote: > ...
4 years, 11 months ago (2016-01-26 20:25:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632123003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632123003/160001
4 years, 11 months ago (2016-01-26 20:39:49 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/139192)
4 years, 11 months ago (2016-01-26 20:48:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632123003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632123003/180001
4 years, 11 months ago (2016-01-26 20:59:59 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/164666)
4 years, 11 months ago (2016-01-26 23:41:10 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632123003/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632123003/180001
4 years, 11 months ago (2016-01-27 00:03:57 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:180001)
4 years, 11 months ago (2016-01-27 01:11:25 UTC) #30
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 01:12:21 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/512935cc3fb94185ee159d8e60c95dadc3c001e4
Cr-Commit-Position: refs/heads/master@{#371668}

Powered by Google App Engine
This is Rietveld 408576698