Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2497)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h

Issue 1632113004: ServiceWorker: Add initial implementation of ExtendableMessageEvent behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
index df94ff5e791c9db7ddfa8c4f3865b6c7b25a25cc..0e38cae305ee0911b9547778ff84a51cb0d92f70 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
@@ -55,18 +55,17 @@ public:
virtual void setRegistration(WebPassOwnPtr<WebServiceWorkerRegistration::Handle>) = 0;
virtual void dispatchActivateEvent(int eventID) = 0;
- // FIXME: This needs to pass the active service worker info.
- virtual void dispatchInstallEvent(int installEventID) = 0;
- virtual void dispatchFetchEvent(int fetchEventID, const WebServiceWorkerRequest& webRequest) = 0;
-
+ virtual void dispatchExtendableMessageEvent(int eventID, const WebString& message, const WebMessagePortChannelArray& channels) = 0;
falken 2016/01/29 09:47:52 nit: the "channels" name can probably be removed
nhiroki 2016/02/01 02:05:28 Done.
+ virtual void dispatchInstallEvent(int eventID) = 0;
+ virtual void dispatchFetchEvent(int eventID, const WebServiceWorkerRequest& webRequest) = 0;
virtual void dispatchGeofencingEvent(int eventID, WebGeofencingEventType, const WebString& regionID, const WebCircularGeofencingRegion&) = 0;
+ // TODO(nhiroki): Remove this after ExtendableMessageEvent is enabled by
+ // default (crbug.com/543198).
virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray& channels) = 0;
falken 2016/01/29 09:47:52 nit: here too
nhiroki 2016/02/01 02:05:28 Done.
virtual void dispatchNotificationClickEvent(int eventID, int64_t notificationID, const WebNotificationData&, int actionIndex) = 0;
-
virtual void dispatchPushEvent(int eventID, const WebString& data) = 0;
-
virtual void dispatchCrossOriginMessageEvent(const WebCrossOriginServiceWorkerClient&, const WebString& message, const WebMessagePortChannelArray&) = 0;
// Passes ownership of the callbacks.

Powered by Google App Engine
This is Rietveld 408576698