Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc

Issue 1632053002: Fix flaky CertificateProviderApiTest.Basic test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
index 4e0e1fcccf022fab5c7d43ddd3bac88ae391b46e..8d7913dbc06cb064d3e265068d253a2614770ae2 100644
--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc
@@ -159,13 +159,7 @@ class CertificateProviderApiTest : public ExtensionApiTest {
} // namespace
-// See crbug.com/576364 for details
-#if defined(OS_CHROMEOS)
-#define MAYBE_Basic DISABLED_Basic
-#else
-#define MAYBE_Basic Basic
-#endif
-IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, MAYBE_Basic) {
+IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, Basic) {
// Start an HTTPS test server that requests a client certificate.
net::SpawnedTestServer::SSLOptions ssl_options;
ssl_options.request_client_certificate = true;
@@ -197,6 +191,9 @@ IN_PROC_BROWSER_TEST_F(CertificateProviderApiTest, MAYBE_Basic) {
content::WebContents* const https_contents =
browser()->tab_strip_model()->GetActiveWebContents();
+ VLOG(1) << "Wait for the extension to respond to the certificates request.";
+ ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
+
VLOG(1) << "Wait for the extension to receive the sign request.";
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698