Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1632053002: Fix flaky CertificateProviderApiTest.Basic test. (Closed)

Created:
4 years, 11 months ago by emaxx
Modified:
4 years, 11 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky CertificateProviderApiTest.Basic test. The flakiness was caused by waiting for a wrong number of JavaScript test results, which resulted in inconsistency between events that were expected to happen and the events that have actually happened. In a detailed manner, the reportCertificates callback in file basic.js is wrapped through chrome.test.callbackPass method, which itself calls chrome.test.succeed method; meanwhile the C++ code in certificate_provider_apitest.cc didn't expect this chrome.test.succeed call, and it behaved as if the chrome.certificateProvider.onSignDigestRequested event handler was already executed - which is not always true and causes flakiness. BUG=576364 Committed: https://crrev.com/7afe71d1455a7224a9bcfcad352c8cc7cec12324 Cr-Commit-Position: refs/heads/master@{#371501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
emaxx
Bartosz, PTAL.
4 years, 11 months ago (2016-01-26 00:38:09 UTC) #2
bartfab (slow)
lgtm
4 years, 11 months ago (2016-01-26 13:26:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1632053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1632053002/1
4 years, 11 months ago (2016-01-26 13:29:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 13:34:58 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 13:36:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7afe71d1455a7224a9bcfcad352c8cc7cec12324
Cr-Commit-Position: refs/heads/master@{#371501}

Powered by Google App Engine
This is Rietveld 408576698