Define EncodedVideoSource and RtcCapturedEncodingVideoCapturer.

media/video/capture/video_capture.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains abstract classes used for media filter to handle video
 // capture devices.
 
 #ifndef MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_H_
 #define MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/time.h"
 #include "media/base/media_export.h"
 #include "media/base/video_frame.h"
 #include "media/video/capture/video_capture_types.h"
 
 namespace media {
 
+class EncodedVideoSource;
+
 class MEDIA_EXPORT VideoCapture {
  public:
   // TODO(wjia): consider merging with media::VideoFrame if possible.
   class VideoFrameBuffer : public base::RefCountedThreadSafe<VideoFrameBuffer> {
    public:
     VideoFrameBuffer()
         : width(0),
           height(0),
           stride(0),
           buffer_size(0),
@@ skipping 60 matching lines @@
   virtual void StopCapture(EventHandler* handler) = 0;
 
   // Feed buffer to video capture when done with it.
   virtual void FeedBuffer(scoped_refptr<VideoFrameBuffer> buffer) = 0;
 
   virtual bool CaptureStarted() = 0;
   virtual int CaptureWidth() = 0;
   virtual int CaptureHeight() = 0;
   virtual int CaptureFrameRate() = 0;
 
+  // Tells the client whether platform and camera has encoding support.
+  // The operation of encoder is tied to capture controlled by the functions
+  // of VideoCapture interface. E.g. calling VideoCapture::StopCapture() will
+  // also stop the streaming of encoded streams.

[Ami GONE FROM CHROMIUM, 2013/06/08 00:18:01]

This is not enough information.  For example it implies one still calls
VideoCapture::StartCapture() to start getting encoded bitstreambuffers, but it
doesn't say what to pass for a  the |handler| param to StartCapture.  It sort of
implies that raw frames will be returned to the handler while
encodedbitstreambuffers will be returned to the EVS::Client registered with
Initialize.

[hshi1, 2013/06/11 17:49:42]

I realized it is completely unnecessary to change this header at all. I'm
reverting it. There is no reason to add this method in the VideoCapture
interface. The base VideoCapture interface will always have no encoding
capabilities. This way I don't have to deal with pepper video capture either.

+  // All platforms or cameras may have not encoding support available.

[Ami GONE FROM CHROMIUM, 2013/06/08 00:18:01]

Comment is written as if this returns a bool, not a pointer.

[Ami GONE FROM CHROMIUM, 2013/06/08 00:18:01]

If this was impl'd to return NULL (in a new video_capture.cc file) then you
wouldn't need to propagate this as a do-nothing to
pepper_platform_video_capture_impl.cc and so on.

(there's no value to this being a pure abstract class)

[hshi1, 2013/06/11 17:49:42]

N/A (file reverted).

[hshi1, 2013/06/11 17:49:42]

N/A (file reverted).

+  virtual EncodedVideoSource* GetEncodedVideoSource() = 0;

[Ami GONE FROM CHROMIUM, 2013/06/08 00:18:01]

What are the ownership semantics of the returned pointer?

[hshi1, 2013/06/11 17:49:42]

N/A (file reverted).

+
  protected:
   virtual ~VideoCapture() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(VideoCapture);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_H_