Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1631973003: [turbofan] Fixing IMulHigh, which has a temp. (Closed)

Created:
4 years, 10 months ago by Mircea Trofin
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fixing IMulHigh, which has a temp. On Intel, imul clobbers {r|e}ax. We're missing that in the representation of the MulHigh intermediate instructions. Fixing, by adding it as a temp, akin VisitDiv does. Committed: https://crrev.com/a685180d38fe6c8b8878e8b0638e475221be37fe Cr-Commit-Position: refs/heads/master@{#33535}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Mircea Trofin
4 years, 10 months ago (2016-01-27 04:25:02 UTC) #4
Benedikt Meurer
Nice. LGTM.
4 years, 10 months ago (2016-01-27 05:08:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631973003/40001
4 years, 10 months ago (2016-01-27 06:38:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-01-27 06:39:49 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 06:40:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a685180d38fe6c8b8878e8b0638e475221be37fe
Cr-Commit-Position: refs/heads/master@{#33535}

Powered by Google App Engine
This is Rietveld 408576698