Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1631973002: Revert of Remove Metro mode avatar/profile switcher assets (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 11 months ago
Reviewers:
msw, oshima
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Metro mode avatar/profile switcher assets (patchset #2 id:20001 of https://codereview.chromium.org/1605243002/ ) Reason for revert: Broke Win10 BUG=581097 Original issue's description: > Remove Metro mode avatar/profile switcher assets > > BUG=558054 > > Committed: https://crrev.com/327f4816de86c9408c8638e9c91add65424affd3 > Cr-Commit-Position: refs/heads/master@{#370906} TBR=msw@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=558054 Committed: https://crrev.com/ed9a4eaa3adf649551028f9ace5f444683b3f0fa Cr-Commit-Position: refs/heads/master@{#371333}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_avatar.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_bottom.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_bottom_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_bottom_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_center.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_bottom.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_bottom_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_bottom_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_center.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_top.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_top_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_hover_top_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_bottom.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_bottom_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_bottom_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_center.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_top.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_top_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_pressed_top_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_right.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_top.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_top_left.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/win/avatar_button/win8/sign_in_button_top_right.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tapted
Created Revert of Remove Metro mode avatar/profile switcher assets
4 years, 11 months ago (2016-01-25 21:23:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631973002/1
4 years, 11 months ago (2016-01-25 21:25:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631973002/1
4 years, 11 months ago (2016-01-25 21:34:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631973002/1
4 years, 11 months ago (2016-01-25 22:03:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 22:15:14 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:16:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed9a4eaa3adf649551028f9ace5f444683b3f0fa
Cr-Commit-Position: refs/heads/master@{#371333}

Powered by Google App Engine
This is Rietveld 408576698