content/browser/renderer_host/input/input_router_impl.cc - Issue 1631963002: Plumb firing passive event listeners.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl.cc

Issue 1631963002: Plumb firing passive event listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_wheel_passive_listeners_2a

Patch Set: Renamed enum value as per wez@ request Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/in_process/synchronous_input_event_filter.cc ('k') | content/browser/renderer_host/input/non_blocking_event_browsertest.cc » ('j') | content/browser/renderer_host/input/non_blocking_event_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/input_router_impl.cc

diff --git a/content/browser/renderer_host/input/input_router_impl.cc b/content/browser/renderer_host/input/input_router_impl.cc

index 8ba92878d8495526c70dfb2079da9c5359d9ab7d..9f79fb4cbed4198e7e2156dbb427e8cf044eea14 100644

--- a/content/browser/renderer_host/input/input_router_impl.cc

+++ b/content/browser/renderer_host/input/input_router_impl.cc

@@ -53,6 +53,8 @@ const char* GetEventAckName(InputEventAckState ack_result) {

case INPUT_EVENT_ACK_STATE_NOT_CONSUMED: return "NOT_CONSUMED";

case INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS: return "NO_CONSUMER_EXISTS";

case INPUT_EVENT_ACK_STATE_IGNORED: return "IGNORED";

+ case INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING:

+ return "SET_NON_BLOCKING";

}

DLOG(WARNING) << "Unhandled InputEventAckState in GetEventAckName.";

return "";

@@ -410,8 +412,9 @@ bool InputRouterImpl::OfferToRenderer(const WebInputEvent& input_event,

const WebInputEvent* event_to_send =

event_in_viewport ? event_in_viewport.get() : &input_event;

- if (Send(new InputMsg_HandleInputEvent(routing_id(), event_to_send,

- latency_info))) {

+ if (Send(new InputMsg_HandleInputEvent(

+ routing_id(), event_to_send, latency_info,

+ InputEventDispatchType::DISPATCH_TYPE_NORMAL))) {

// Ack messages for ignored ack event types should never be sent by the

// renderer. Consequently, such event types should not affect event time

// or in-flight event count metrics.