Plumb firing passive event listeners.

content/renderer/idle_user_detector.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_IDLE_USER_DETECTOR_H_
 #define CONTENT_RENDERER_IDLE_USER_DETECTOR_H_
 
 #include "base/macros.h"
 #include "content/public/renderer/render_view_observer.h"
 
@@ skipping 12 matching lines @@
 class IdleUserDetector : public RenderViewObserver {
  public:
   IdleUserDetector(RenderView* render_view);
   ~IdleUserDetector() override;
 
  private:
   // RenderViewObserver implementation:
   bool OnMessageReceived(const IPC::Message& message) override;
 
   void OnHandleInputEvent(const blink::WebInputEvent* event,
-                          const ui::LatencyInfo& latency_info);
+                          const ui::LatencyInfo& latency_info,
+                          bool passive);

[tdresser, 2016/01/26 16:34:37]

Should this method (thoughout) take an enum? There's a bunch of places where we
call this with a raw boolean literal, which makes it unclear what the purpose of
the parameter is.

[dtapuska, 2016/01/26 16:53:15]

sgtm; suggested name? Its like the event calling disposition/state.

[tdresser, 2016/01/26 18:45:42]

Something like a RenderViewObserver::IsBlocking enum, with values Passive and
Blocking?

 
   DISALLOW_COPY_AND_ASSIGN(IdleUserDetector);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_IDLE_USER_DETECTOR_H_