Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1631953002: Stack sampling profiler: increase enable rate to 50% (Closed)

Created:
4 years, 11 months ago by Mike Wittman
Modified:
4 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stack sampling profiler: increase enable rate to 50% All crashers of any significance have been addressed as of 85285916c45c2aba7d7b3a0227fd71ec047d758d. This is the next step towards increasing the enable rate to 100%. BUG=541419 Committed: https://crrev.com/efb4ee0a3ff006080b4cfcb9d94b4971a323caaf Cr-Commit-Position: refs/heads/master@{#371364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/stack_sampling_configuration.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike Wittman
Hi Carlos, can you approve increasing the stack profiler enable rate? All the data quality ...
4 years, 11 months ago (2016-01-25 20:58:38 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
4 years, 11 months ago (2016-01-25 22:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631953002/1
4 years, 11 months ago (2016-01-25 22:38:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 00:12:55 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:18:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efb4ee0a3ff006080b4cfcb9d94b4971a323caaf
Cr-Commit-Position: refs/heads/master@{#371364}

Powered by Google App Engine
This is Rietveld 408576698