Sync 3rd party wallpaper app name

chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var WALLPAPER_PICKER_WIDTH = 574;
 var WALLPAPER_PICKER_HEIGHT = 420;
 
 var wallpaperPickerWindow;
 
 var surpriseWallpaper = null;
@@ skipping 254 matching lines @@
       chrome.wallpaperPrivate.restoreMinimizedWindows();
     });
     WallpaperUtil.testSendMessage('wallpaper-window-created');
   });
 });
 
 chrome.syncFileSystem.onFileStatusChanged.addListener(function(detail) {
   WallpaperUtil.enabledSyncThemesCallback(function(syncEnabled) {
     if (!syncEnabled)
       return;
-    if (detail.status == 'synced') {
-      if (detail.direction == 'remote_to_local') {
-        if (detail.action == 'added') {
-          Constants.WallpaperLocalStorage.get(
-              Constants.AccessLocalWallpaperInfoKey,
-              function(items) {
-                var localData = items[Constants.AccessLocalWallpaperInfoKey];
-                if (localData && localData.url == detail.fileEntry.name &&
-                    localData.source == Constants.WallpaperSourceEnum.Custom) {
-                  WallpaperUtil.setCustomWallpaperFromSyncFS(localData.url,
-                                                             localData.layout);
-                } else if (!localData || localData.url !=
-                           detail.fileEntry.name.replace(
-                               Constants.CustomWallpaperThumbnailSuffix, '')) {
-                  // localData might be null on a powerwashed device.
-                  WallpaperUtil.storeWallpaperFromSyncFSToLocalFS(
-                      detail.fileEntry);
-                }
-             });
-        } else if (detail.action == 'deleted') {
-          var fileName = detail.fileEntry.name.replace(
-              Constants.CustomWallpaperThumbnailSuffix, '');
-          WallpaperUtil.deleteWallpaperFromLocalFS(fileName);
+    if (detail.status != 'synced' || detail.direction != 'remote_to_local')
+      return;
+    if (detail.action == 'added') {
+      // TODO(xdai): Get rid of this setCustomWallpaperFromSyncFS logic.
+      // WallpaperInfo might have been saved in the sync filesystem before the
+      // corresonding custom wallpaper and thumbnail are saved, thus the
+      // onChanged() might not set the custom wallpaper correctly. So we need
+      // setCustomWallpaperFromSyncFS() to be called here again to make sure
+      // custom wallpaper is set.
+      Constants.WallpaperLocalStorage.get(
+          Constants.AccessLocalWallpaperInfoKey, function(items) {
+        var localData = items[Constants.AccessLocalWallpaperInfoKey];
+        if (localData &&
+            localData.url == detail.fileEntry.name &&
+            localData.source == Constants.WallpaperSourceEnum.Custom) {
+          WallpaperUtil.setCustomWallpaperFromSyncFS(localData.url,
+                                                     localData.layout);
         }
+      });
+      // We only need to store the custom wallpaper if it was set by the
+      // built-in wallpaper picker.
+      if (detail.fileEntry.name.indexOf(

[tbarzic, 2016/02/06 01:50:14]

nit: I'll assume build in wallpaper cannot have thirdPartyPrefix somewhere in
the name.
Still, != 0 should probably be more precise :)

[xdai1, 2016/02/09 18:25:02]

Done.

+          Constants.ThirdPartyWallpaperPrefix) == -1) {
+        WallpaperUtil.storeWallpaperFromSyncFSToLocalFS(detail.fileEntry);
       }
+    } else if (detail.action == 'deleted') {
+      var fileName = detail.fileEntry.name.replace(
+          Constants.CustomWallpaperThumbnailSuffix, '');
+      WallpaperUtil.deleteWallpaperFromLocalFS(fileName);
     }
   });
 });
 
 chrome.storage.onChanged.addListener(function(changes, namespace) {
   WallpaperUtil.enabledSyncThemesCallback(function(syncEnabled) {
     if (syncEnabled) {
       // If sync theme is enabled, use values from chrome.storage.sync to sync
       // wallpaper changes.
       WallpaperUtil.requestSyncFS(function() {});
       if (changes[Constants.AccessSyncSurpriseMeEnabledKey]) {
         if (changes[Constants.AccessSyncSurpriseMeEnabledKey].newValue) {
           SurpriseWallpaper.getInstance().next();
         } else {
           SurpriseWallpaper.getInstance().disable();
         }
       }
 
       if (changes[Constants.AccessLocalWallpaperInfoKey]) {
         // If the old wallpaper is a third party wallpaper we should remove it
         // from the local & sync file system to free space.
         var oldInfo = changes[Constants.AccessLocalWallpaperInfoKey].oldValue;
-        if (oldInfo.url.indexOf(Constants.ThirdPartyWallpaperPrefix) != -1) {
+        if (oldInfo &&
+            oldInfo.url.indexOf(Constants.ThirdPartyWallpaperPrefix) != -1) {
           WallpaperUtil.deleteWallpaperFromLocalFS(oldInfo.url);
           WallpaperUtil.deleteWallpaperFromSyncFS(oldInfo.url);
         }
       }
 
       if (changes[Constants.AccessSyncWallpaperInfoKey]) {
         var syncInfo = changes[Constants.AccessSyncWallpaperInfoKey].newValue;
 
         Constants.WallpaperSyncStorage.get(
             Constants.AccessSyncSurpriseMeEnabledKey, function(enabledItems) {
@@ skipping 14 matching lines @@
                 (syncSurpriseMeEnabled &&
                  syncLastSurpriseMeChangedDate == today)) {
               Constants.WallpaperLocalStorage.get(
                   Constants.AccessLocalWallpaperInfoKey, function(infoItems) {
                 var localInfo =
                     infoItems[Constants.AccessLocalWallpaperInfoKey];
                 // Normally, the wallpaper info saved in local storage and sync
                 // storage are the same. If the synced value changed by sync
                 // service, they may different. In that case, change wallpaper
                 // to the one saved in sync storage and update the local value.
-                if (localInfo == undefined ||
+                if (!localInfo ||
                     localInfo.url != syncInfo.url ||
                     localInfo.layout != syncInfo.layout ||
                     localInfo.source != syncInfo.source) {
                   if (syncInfo.source == Constants.WallpaperSourceEnum.Online) {
                     // TODO(bshe): Consider schedule an alarm to set online
                     // wallpaper later when failed. Note that we need to cancel
                     // the retry if user set another wallpaper before retry
                     // alarm invoked.
                     WallpaperUtil.setOnlineWallpaper(syncInfo.url,
                         syncInfo.layout, function() {}, function() {});
@@ skipping 34 matching lines @@
       }
     }
   });
 });
 
 chrome.alarms.onAlarm.addListener(function() {
   SurpriseWallpaper.getInstance().next();
 });
 
 chrome.wallpaperPrivate.onWallpaperChangedBy3rdParty.addListener(function(
-    wallpaper, thumbnail, layout) {
+    wallpaper, thumbnail, layout, appName) {
   WallpaperUtil.saveToLocalStorage(
       Constants.AccessLocalSurpriseMeEnabledKey, false, function() {
     WallpaperUtil.saveToSyncStorage(Constants.AccessSyncSurpriseMeEnabledKey,
                                     false);
   });
   SurpriseWallpaper.getInstance().disable();
 
   // Make third party wallpaper syncable through different devices.
-  // TODO(xdai): also sync the third party app name.
   var filename = Constants.ThirdPartyWallpaperPrefix + new Date().getTime();
   var thumbnailFilename = filename + Constants.CustomWallpaperThumbnailSuffix;
   WallpaperUtil.storeWallpaperToSyncFS(filename, wallpaper);
   WallpaperUtil.storeWallpaperToSyncFS(thumbnailFilename, thumbnail);
-  WallpaperUtil.saveWallpaperInfo(filename, layout,
-                                  Constants.WallpaperSourceEnum.Custom);
+  WallpaperUtil.saveWallpaperInfo(
+      filename, layout, Constants.WallpaperSourceEnum.Custom, appName);
 });