tools/gn/c_include_iterator.cc - Issue 1631873003: Check system-include dependencies in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/c_include_iterator.cc

Issue 1631873003: Check system-include dependencies in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/c_include_iterator.cc

diff --git a/tools/gn/c_include_iterator.cc b/tools/gn/c_include_iterator.cc

index cc3cb35d27f1c0120b979409841a94d2b0c7cff6..28654a7a746a6f52bb734c281202c154b49e4201 100644

--- a/tools/gn/c_include_iterator.cc

+++ b/tools/gn/c_include_iterator.cc

@@ -134,8 +134,7 @@ bool CIncludeIterator::GetNextIncludeString(base::StringPiece* out,

base::StringPiece include_contents;

int begin_char;

IncludeType type = ExtractInclude(line, &include_contents, &begin_char);

- if (type == INCLUDE_USER && !HasNoCheckAnnotation(line)) {

- // Only count user includes for now.

+ if (type != INCLUDE_NONE && !HasNoCheckAnnotation(line)) {

*out = include_contents;

*location = LocationRange(

Location(input_file_,

« no previous file with comments | « AUTHORS ('k') | tools/gn/c_include_iterator_unittest.cc » ('j') | no next file with comments »