Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1631863003: Merge to XFA: Remove CFX_SegmentedArray use from master. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove CFX_SegmentedArray use from master. Unfortunately, it is still used on the xfa/ side, so exclude it only for non-xfa builds. Original Review URL: https://codereview.chromium.org/1618273004 . (cherry picked from commit c64e4007ee4561ec2ed3ce986191caf9b024ef55) TBR=ochang@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/52bb44383a705b600e0d028bff5ade17856f5a60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -234 lines) Patch
M core/include/fxcrt/fx_basic.h View 2 chunks +2 lines, -0 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 40 chunks +185 lines, -220 lines 0 comments Download
M core/src/fpdftext/text_int.h View 5 chunks +14 lines, -14 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/base/stl_util.h View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, trivial changes in fx_basic.h and fx_basic_array.cpp
4 years, 11 months ago (2016-01-25 23:47:53 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 52bb44383a705b600e0d028bff5ade17856f5a60 (presubmit successful).
4 years, 11 months ago (2016-01-25 23:56:06 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-26 00:03:18 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698