Adds EnableReadingList experimental flag.

Adds EnableReadingList experimental flag.

Adds a new experimental flag for Reading List on iOS. The flag is
toggled with Settings.bundle downstream.

BUG=581014
Committed: https://crrev.com/23ab73d803cddb6bb6d60dc0fa65334a8054677e
Cr-Commit-Position: refs/heads/master@{#371503}

[stkhapugin, 2016-01-25 17:10:58]

stkhapugin@chromium.org changed reviewers:
+ noyau@chromium.org

[stkhapugin, 2016-01-25 17:10:59]

PTAL.

[Olivier, 2016-01-25 17:26:38]

olivierrobin@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[Olivier, 2016-01-25 17:26:39]

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
File ios/chrome/browser/experimental_flags.mm (right):

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
ios/chrome/browser/experimental_flags.mm:243: if ([[NSUserDefaults
standardUserDefaults] boolForKey:kEnableReadingList]) {
why not just return [NSUserDefaults... boolForKey:...]

[sdefresne, 2016-01-26 10:03:14]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-01-26 10:03:15]

lgtm

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
File ios/chrome/browser/experimental_flags.h (right):

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
ios/chrome/browser/experimental_flags.h:60: // YES if the reading list is
enabled.
drive-by: maybe something like "Whether the reading list is enabled." to follow
the other comments (and to avoid misleading the developer as the function
returns a bool, not a BOOL, so the value is either true/false, not YES/NO).

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
File ios/chrome/browser/experimental_flags.mm (right):

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
ios/chrome/browser/experimental_flags.mm:243: if ([[NSUserDefaults
standardUserDefaults] boolForKey:kEnableReadingList]) {
On 2016/01/25 at 17:26:39, Olivier Robin wrote:
> why not just return [NSUserDefaults... boolForKey:...]

+1

[stkhapugin, 2016-01-26 12:28:33]

PTAL

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
File ios/chrome/browser/experimental_flags.h (right):

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
ios/chrome/browser/experimental_flags.h:60: // YES if the reading list is
enabled.
On 2016/01/26 10:03:15, sdefresne (OOO till Feb 1st) wrote:
> drive-by: maybe something like "Whether the reading list is enabled." to
follow
> the other comments (and to avoid misleading the developer as the function
> returns a bool, not a BOOL, so the value is either true/false, not YES/NO).

Done.

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
File ios/chrome/browser/experimental_flags.mm (right):

https://codereview.chromium.org/1631813002/diff/1/ios/chrome/browser/experime...
ios/chrome/browser/experimental_flags.mm:243: if ([[NSUserDefaults
standardUserDefaults] boolForKey:kEnableReadingList]) {
On 2016/01/25 17:26:39, Olivier Robin wrote:
> why not just return [NSUserDefaults... boolForKey:...]

Done.

[Olivier, 2016-01-26 12:29:43]

lgtm

[noyau (Ping after 24h), 2016-01-26 13:26:40]

The CQ bit was checked by noyau@chromium.org

[noyau (Ping after 24h), 2016-01-26 13:26:41]

lgtm

[noyau (Ping after 24h), 2016-01-26 13:26:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1631813002/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-01-26 13:27:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631813002/20001

[commit-bot: I haz the power, 2016-01-26 13:45:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 13:46:04]

Description was changed from

==========
Adds EnableReadingList experimental flag.

Adds a new experimental flag for Reading List on iOS. The flag is
toggled with Settings.bundle downstream.

BUG=581014
==========

to

==========
Adds EnableReadingList experimental flag.

Adds a new experimental flag for Reading List on iOS. The flag is
toggled with Settings.bundle downstream.

BUG=581014

Committed: https://crrev.com/23ab73d803cddb6bb6d60dc0fa65334a8054677e
Cr-Commit-Position: refs/heads/master@{#371503}
==========

[commit-bot: I haz the power, 2016-01-26 13:46:05]

Patchset 2 (id:??) landed as
https://crrev.com/23ab73d803cddb6bb6d60dc0fa65334a8054677e
Cr-Commit-Position: refs/heads/master@{#371503}