Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 1631803003: Fix building of closure type arguments (fixes #25543). (Closed)

Created:
4 years, 11 months ago by regis
Modified:
4 years, 11 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix building of closure type arguments (fixes #25543). Re-enable skipped test with --noopt. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/b116694c84aecacaee79ee996f58e0a84990ac80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 11 months ago (2016-01-25 21:38:53 UTC) #2
hausner
lgtm
4 years, 11 months ago (2016-01-25 21:41:56 UTC) #3
regis
4 years, 11 months ago (2016-01-25 21:58:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b116694c84aecacaee79ee996f58e0a84990ac80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698