Issue 16318003: Fix iOS build for webP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16318003: Fix iOS build for webP (Closed)

Created:
7 years, 6 months ago by djsollen

Modified:
7 years, 6 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

update WebP to a dev version of 0.3.1 This is necessary to pick up a NEON fix for the iOS build. R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=9516

Patch Set 9 : this works #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	DEPS	View	1 2 3 4 5 6 7 8	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

borenet

https://codereview.chromium.org/16318003/diff/1/gyp/libwebp.gyp File gyp/libwebp.gyp (right): https://codereview.chromium.org/16318003/diff/1/gyp/libwebp.gyp#newcode70 gyp/libwebp.gyp:70: ['skia_os in ["android", "ios"]', { What about x86 Android? ...

7 years, 6 months ago (2013-06-11 12:20:07 UTC) #2

djsollen

7 years, 6 months ago (2013-06-11 20:03:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #9 manually as r9516 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16318003: Fix iOS build for webP (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : this works #

Messages