CLI support for embedders (#25380).

CLI support for embedders (#25380).

Background here: https://github.com/dart-lang/sdk/issues/25380

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3d3c9c5af46ffed91786672872006cba8581f533

[pquitslund, 2016-01-26 19:01:11]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-26 19:12:33]

LGTM

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:307: CommandLineOptions options,
AnalysisContext context) {
Given that the only thing we need from the context is the embedderYamlLocator,
perhaps we should just pass it in directly. I'm concerned that passing the
context in to a method used to configure the context will lead to errors when
someone thinks they have a fully initialized context. Maybe I'm being overly
cautions.

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/test/embed...
File pkg/analyzer_cli/test/embedder_test.dart (right):

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/test/embed...
pkg/analyzer_cli/test/embedder_test.dart:31: initializeTestEnvironment();
Perhaps move outside the group?

[pquitslund, 2016-01-26 19:22:20]

Thanks!

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:307: CommandLineOptions options,
AnalysisContext context) {
On 2016/01/26 19:12:33, Brian Wilkerson wrote:
> Given that the only thing we need from the context is the embedderYamlLocator,
> perhaps we should just pass it in directly. I'm concerned that passing the
> context in to a method used to configure the context will lead to errors when
> someone thinks they have a fully initialized context. Maybe I'm being overly
> cautions.

Done.

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/test/embed...
File pkg/analyzer_cli/test/embedder_test.dart (right):

https://codereview.chromium.org/1631763007/diff/1/pkg/analyzer_cli/test/embed...
pkg/analyzer_cli/test/embedder_test.dart:31: initializeTestEnvironment();
On 2016/01/26 19:12:33, Brian Wilkerson wrote:
> Perhaps move outside the group?

Done.

[pquitslund, 2016-01-26 19:33:18]

Description was changed from

==========
CLI support for embedders (#25380).

Background here: https://github.com/dart-lang/sdk/issues/25380

BUG=
==========

to

==========
CLI support for embedders (#25380).

Background here: https://github.com/dart-lang/sdk/issues/25380

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3d3c9c5af46ffed91786672872006cba8581f533
==========

[pquitslund, 2016-01-26 19:33:20]

Committed patchset #1 (id:1) manually as
3d3c9c5af46ffed91786672872006cba8581f533 (presubmit successful).