Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 163173003: Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (Closed)

Created:
6 years, 10 months ago by jungshik at Google
Modified:
6 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vapier
Visibility:
Public.

Description

Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/164333003/) Reason for revert: CrOS-side change (chromeos-chrome.ebuild) may not be used by a buildbot. ./1_autotest_tests/results-27-experimental_login_OwnershipNotRetaken/login_OwnershipNotRetaken/sysinfo/var/log/ui/ui.LATEST still has [0214/002103:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU() Original issue's description: > Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/) > > Reason for revert: > https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. > > Original issue's description: > > Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/) > > > > Reason for revert: > > https://chromium-review.googlesource.com/#/c/185937/ has to go in first. > > > > > > Original issue's description: > > > Turn on icu_use_data_file_flag on CrOS > > > > > > See also https://chromium-review.googlesource.com/#/c/185937/ > > > > > > The switch has to be turned on in two places (chromeos-chrome.ebuild and > > > build/common.gypi). One or the other can get landed separately, though. > > > > > > BUG=72633 > > > TEST=net_unittests:*IDN* and base_unittests:*String* > > > TBR=mark > > > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213 > > > > TBR=mark@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=72633 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214 > > TBR=mark@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=72633 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251220 TBR=mark@chromium.org NOTREECHECKS=true NOTRY=true BUG=72633 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
Created Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS
6 years, 10 months ago (2014-02-14 08:50:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/163173003/1
6 years, 10 months ago (2014-02-14 08:50:38 UTC) #2
commit-bot: I haz the power
Change committed as 251276
6 years, 10 months ago (2014-02-14 08:50:54 UTC) #3
jungshik at Google
A revert of this CL has been created in https://codereview.chromium.org/166513002/ by jshin@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-14 10:20:54 UTC) #4
Mark Mentovai
6 years, 10 months ago (2014-02-14 13:38:32 UTC) #5
Message was sent while issue was closed.
LGTM

It’s getting hard to keep these straight.

Powered by Google App Engine
This is Rietveld 408576698