Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1631673002: Also check new_target_is_base() bit when comparing two maps for equivalence. (Closed)

Created:
4 years, 11 months ago by Igor Sheludko
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Also check new_target_is_base() bit when comparing two maps for equivalence. BUG=chromium:580506 LOG=N Committed: https://crrev.com/ac03ef02d6f33a4cf087df42141d28ec3a5ad98d Cr-Commit-Position: refs/heads/master@{#33497}

Patch Set 1 #

Patch Set 2 : Skip new test for ignition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-580506.js View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Igor Sheludko
PTAL
4 years, 11 months ago (2016-01-25 15:18:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631673002/1
4 years, 11 months ago (2016-01-25 15:20:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12800)
4 years, 11 months ago (2016-01-25 15:34:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631673002/20001
4 years, 11 months ago (2016-01-25 15:43:45 UTC) #8
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-25 16:00:17 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 16:09:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631673002/20001
4 years, 11 months ago (2016-01-25 16:42:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 16:43:35 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 16:44:08 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ac03ef02d6f33a4cf087df42141d28ec3a5ad98d
Cr-Commit-Position: refs/heads/master@{#33497}

Powered by Google App Engine
This is Rietveld 408576698