Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163163002: top and bottom black background line not getting displayed (Closed)

Created:
6 years, 10 months ago by Gurpreet
Modified:
6 years, 9 months ago
CC:
blink-reviews, mstensho+blink_opera.com, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., lgombos, gyuyoung2, ryuan, tonikitoo_
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

top and bottom black background line not getting displayed The table cell's background was not being displayed. Since the table cell had no child correct offsetWidth was not being set even if table width is being defined. cellHasContent should also be set to true incase background color is present. I already landed this patch on Webkit. Just modified the layout test file. http://trac.webkit.org/changeset/160410. R=jchaffraix@chromium.org BUG=343482 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168119

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
A LayoutTests/fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTableElement/empy-table-cell-with-background-color-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/table/auto-100-percent-width-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/table/empty-cells-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/table/empty-cells-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/table/empty-cells-expected.png View 1 2 3 Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/fast/table/empty-cells-expected.png View 1 2 3 Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/table/empty-cells-expected.png View 1 2 3 Binary file 0 comments Download
M LayoutTests/platform/mac/fast/table/auto-100-percent-width-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/mac/fast/table/empty-cells-expected.png View 1 2 3 Binary file 0 comments Download
M LayoutTests/platform/win/fast/table/auto-100-percent-width-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/win/fast/table/empty-cells-expected.png View 1 2 Binary file 0 comments Download
M LayoutTests/platform/win/fast/table/empty-cells-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/tables/mozilla/bugs/bug1818-6-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/AutoTableLayout.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Gurpreet
Please review. Thanks.
6 years, 10 months ago (2014-02-19 09:58:46 UTC) #1
Julien - ping for review
lgtm
6 years, 10 months ago (2014-02-21 20:35:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.gurpreet@samsung.com/163163002/1
6 years, 10 months ago (2014-02-21 20:35:29 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 22:14:58 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13613
6 years, 10 months ago (2014-02-21 22:14:59 UTC) #5
Gurpreet
The CQ bit was checked by k.gurpreet@samsung.com
6 years, 9 months ago (2014-02-27 12:47:17 UTC) #6
Gurpreet
The CQ bit was unchecked by k.gurpreet@samsung.com
6 years, 9 months ago (2014-02-27 12:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.gurpreet@samsung.com/163163002/230001
6 years, 9 months ago (2014-02-27 12:47:22 UTC) #8
Gurpreet
The CQ bit was checked by k.gurpreet@samsung.com
6 years, 9 months ago (2014-02-27 12:58:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.gurpreet@samsung.com/163163002/230001
6 years, 9 months ago (2014-02-27 12:59:08 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 14:49:11 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=20290
6 years, 9 months ago (2014-02-27 14:49:12 UTC) #12
Gurpreet
The CQ bit was checked by k.gurpreet@samsung.com
6 years, 9 months ago (2014-02-28 08:13:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.gurpreet@samsung.com/163163002/340001
6 years, 9 months ago (2014-02-28 08:14:15 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 09:32:54 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 9 months ago (2014-02-28 09:32:55 UTC) #16
Gurpreet
The CQ bit was checked by k.gurpreet@samsung.com
6 years, 9 months ago (2014-02-28 10:22:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/k.gurpreet@samsung.com/163163002/360001
6 years, 9 months ago (2014-02-28 10:22:54 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 11:51:47 UTC) #19
Message was sent while issue was closed. 
Change committed as 168119

Powered by Google App Engine
This is Rietveld 408576698