components/web_restrictions/DEPS - Issue 1631603002: Web restrictions component only.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_restrictions/DEPS

Issue 1631603002: Web restrictions component only. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public",	2 "+content/public",
	jochen (gone - plz use gerrit) 2016/02/05 14:55:07 please don't mix browser and renderer stuff in one please don't mix browser and renderer stuff in one target. Instead, create the usual subdirectory structure (browser/common/renderer) and create individual targets for that. It would also be great to include the code that uses this component in the CL, so it's easier to see whether the interface is right. last but not least: tests please aberent 2016/02/19 12:31:18 Done in https://codereview.chromium.org/1684153002 Show quoted text On 2016/02/05 14:55:07, jochen (OOO) wrote: > please don't mix browser and renderer stuff in one target. > > Instead, create the usual subdirectory structure (browser/common/renderer) and > create individual targets for that. Done in https://codereview.chromium.org/1684153002/ Show quoted text > > It would also be great to include the code that uses this component in the CL, > so it's easier to see whether the interface is right. I would prefer to keep this separate, because if I include this, and the tests, the CL becomes unmanageably large. You can see an initial version of its use in https://codereview.chromium.org/1423713015. Show quoted text > > last but not least: tests please Done in https://codereview.chromium.org/1684153002/
3 "+content/shell",

4 "+gin",	3 "+gin",

5 "+sandbox",	4 "+jni",

	5 "+net",

	6 "+third_party/WebKit",

6 ]	7 ]

OLD	NEW