Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 16316002: extensions: Get rid of RequestLocalFileSystemFunction::LocalFileSystemCallbackDispatcher (Closed)

Created:
7 years, 6 months ago by satorux1
Modified:
7 years, 6 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

extensions: Get rid of RequestLocalFileSystemFunction::LocalFileSystemCallbackDispatcher This indirection is no longer necessary. The code is merged to RequestLocalFileSystemFunction. This is a mechanical change, except that DCHECK(BrowserThread::CurrentlyOn(...)) is added in several places. BUG=246091 TEST=Files.app works as before R=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203807

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -108 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h View 1 chunk +26 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 2 2 chunks +88 lines, -106 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
7 years, 6 months ago (2013-06-03 05:23:15 UTC) #1
hashimoto
lgtm https://codereview.chromium.org/16316002/diff/2001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc (right): https://codereview.chromium.org/16316002/diff/2001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc#newcode610 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc:610: bool LogoutUserFunction::RunImpl() { nit: In file_browser_private_api.cc, LogoutUserFunction comes ...
7 years, 6 months ago (2013-06-03 06:05:29 UTC) #2
satorux1
https://codereview.chromium.org/16316002/diff/2001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc (right): https://codereview.chromium.org/16316002/diff/2001/chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc#newcode610 chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc:610: bool LogoutUserFunction::RunImpl() { On 2013/06/03 06:05:29, hashimoto wrote: > ...
7 years, 6 months ago (2013-06-03 07:10:45 UTC) #3
hashimoto
lgtm
7 years, 6 months ago (2013-06-03 07:22:17 UTC) #4
satorux1
7 years, 6 months ago (2013-06-04 01:23:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r203807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698