[for-in] Further refactorings and unification around for-in.

[for-in] Further refactorings and unification around for-in.

Cleanup %ForInPrepare runtime entry, and unify common logic with
%ForInEnumerate (renamed from %GetPropertyNamesFast). Also introduce
a TupleType to properly type JSForInPrepare and its projections w/o
special hacks in the Typer. And fix %ForInNext and JSForInNext to be
consistent with fullcodegen again (after the proxy refactorings last
quarter).

R=jarin@chromium.org
BUG=v8:3650
LOG=n

Committed: https://crrev.com/88f9995d5c65618cbbf82ae20caf4913eaba0eaa
Cr-Commit-Position: refs/heads/master@{#33487}

[Benedikt Meurer, 2016-01-25 09:51:22]

Hey Jaro,

Here's the first fixit sprint for for-in.
Please take a look.

Thanks,
Benedikt

[Jarin, 2016-01-25 10:00:26]

lgtm. Nice!

https://codereview.chromium.org/1631583002/diff/1/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/1631583002/diff/1/src/types.cc#newcode507
src/types.cc:507: if (this->IsTuple()) {
There should be a comment somewhere (probably on the TupleType class def) which
says how the subtyping works on tuples (invariant in tuple elements).

[Benedikt Meurer, 2016-01-25 10:05:05]

https://codereview.chromium.org/1631583002/diff/1/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/1631583002/diff/1/src/types.cc#newcode507
src/types.cc:507: if (this->IsTuple()) {
As discussed offline, not saying anything about that since the rest of the
classes are also undocumented. We'll have to fix that at some point tho.

[Benedikt Meurer, 2016-01-25 10:05:11]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-01-25 10:05:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1631583002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1631583002/1

[commit-bot: I haz the power, 2016-01-25 10:29:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-25 10:30:24]

Description was changed from

==========
[for-in] Further refactorings and unification around for-in.

Cleanup %ForInPrepare runtime entry, and unify common logic with
%ForInEnumerate (renamed from %GetPropertyNamesFast). Also introduce
a TupleType to properly type JSForInPrepare and its projections w/o
special hacks in the Typer. And fix %ForInNext and JSForInNext to be
consistent with fullcodegen again (after the proxy refactorings last
quarter).

R=jarin@chromium.org
BUG=v8:3650
LOG=n
==========

to

==========
[for-in] Further refactorings and unification around for-in.

Cleanup %ForInPrepare runtime entry, and unify common logic with
%ForInEnumerate (renamed from %GetPropertyNamesFast). Also introduce
a TupleType to properly type JSForInPrepare and its projections w/o
special hacks in the Typer. And fix %ForInNext and JSForInNext to be
consistent with fullcodegen again (after the proxy refactorings last
quarter).

R=jarin@chromium.org
BUG=v8:3650
LOG=n

Committed: https://crrev.com/88f9995d5c65618cbbf82ae20caf4913eaba0eaa
Cr-Commit-Position: refs/heads/master@{#33487}
==========

[commit-bot: I haz the power, 2016-01-25 10:30:25]

Patchset 1 (id:??) landed as
https://crrev.com/88f9995d5c65618cbbf82ae20caf4913eaba0eaa
Cr-Commit-Position: refs/heads/master@{#33487}