Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1631563002: Fix build issue in Debug mode (Closed)

Created:
4 years, 11 months ago by william.xie
Modified:
4 years, 10 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build issue in Debug mode Build error: input_handler_proxy.cc:610:1: error: control reaches end of non-void function [-Werror=return-type] BUG= Committed: https://crrev.com/62176a0b43f521853034899aadd00c38a25a9558 Cr-Commit-Position: refs/heads/master@{#371523}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M ui/events/blink/input_handler_proxy.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
william.xie
PTAL
4 years, 11 months ago (2016-01-25 09:28:03 UTC) #3
tdresser
https://codereview.chromium.org/1631563002/diff/1/ui/events/blink/input_handler_proxy.cc File ui/events/blink/input_handler_proxy.cc (right): https://codereview.chromium.org/1631563002/diff/1/ui/events/blink/input_handler_proxy.cc#newcode604 ui/events/blink/input_handler_proxy.cc:604: } else { Just remove the "else {" here, ...
4 years, 11 months ago (2016-01-25 13:10:23 UTC) #4
william.xie
PTAL https://codereview.chromium.org/1631563002/diff/1/ui/events/blink/input_handler_proxy.cc File ui/events/blink/input_handler_proxy.cc (right): https://codereview.chromium.org/1631563002/diff/1/ui/events/blink/input_handler_proxy.cc#newcode604 ui/events/blink/input_handler_proxy.cc:604: } else { On 2016/01/25 13:10:23, tdresser wrote: ...
4 years, 11 months ago (2016-01-26 00:57:09 UTC) #5
tdresser
LGTM
4 years, 10 months ago (2016-01-26 13:28:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1631563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1631563002/20001
4 years, 10 months ago (2016-01-26 15:44:24 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-26 16:41:41 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 16:42:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62176a0b43f521853034899aadd00c38a25a9558
Cr-Commit-Position: refs/heads/master@{#371523}

Powered by Google App Engine
This is Rietveld 408576698