Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/nacl/renderer/plugin/utility.h

Issue 1631413002: NaCl cleanup: Remove not-very-useful debug logging in the plugin code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/plugin/utility.h
diff --git a/components/nacl/renderer/plugin/utility.h b/components/nacl/renderer/plugin/utility.h
index 6b5f58f2a128fe0347f138049e211dea9fce4d5a..359662e1de91c524a995e31eda95d5875046b647 100644
--- a/components/nacl/renderer/plugin/utility.h
+++ b/components/nacl/renderer/plugin/utility.h
@@ -12,8 +12,6 @@
#include <stdint.h>
#include "components/nacl/renderer/ppb_nacl_private.h"
-#include "native_client/src/shared/platform/nacl_threads.h"
-#include "native_client/src/shared/platform/nacl_time.h"
#define SRPC_PLUGIN_DEBUG 1
@@ -22,42 +20,6 @@ namespace plugin {
const PPB_NaCl_Private* GetNaClInterface();
void SetNaClInterface(const PPB_NaCl_Private* nacl_interface);
-// Debugging print utility
-extern int gNaClPluginDebugPrintEnabled;
-extern int NaClPluginPrintLog(const char *format, ...);
-extern int NaClPluginDebugPrintCheckEnv();
-#if SRPC_PLUGIN_DEBUG
-#define INIT_PLUGIN_LOGGING() do { \
- if (-1 == ::plugin::gNaClPluginDebugPrintEnabled) { \
- ::plugin::gNaClPluginDebugPrintEnabled = \
- ::plugin::NaClPluginDebugPrintCheckEnv(); \
- } \
-} while (0)
-
-#define PLUGIN_PRINTF(args) do { \
- INIT_PLUGIN_LOGGING(); \
- if (0 != ::plugin::gNaClPluginDebugPrintEnabled) { \
- ::plugin::NaClPluginPrintLog("PLUGIN %" NACL_PRIu64 ": ", \
- NaClGetTimeOfDayMicroseconds()); \
- ::plugin::NaClPluginPrintLog args; \
- } \
- } while (0)
-
-// MODULE_PRINTF is used in the module because PLUGIN_PRINTF uses a
-// a timer that may not yet be initialized.
-#define MODULE_PRINTF(args) do { \
- INIT_PLUGIN_LOGGING(); \
- if (0 != ::plugin::gNaClPluginDebugPrintEnabled) { \
- ::plugin::NaClPluginPrintLog("MODULE: "); \
- ::plugin::NaClPluginPrintLog args; \
- } \
- } while (0)
-#else
-# define PLUGIN_PRINTF(args) do { if (0) { printf args; } } while (0)
-# define MODULE_PRINTF(args) do { if (0) { printf args; } } while (0)
-/* allows DCE but compiler can still do format string checks */
-#endif
-
} // namespace plugin
#endif // COMPONENTS_NACL_RENDERER_PLUGIN_UTILITY_H_
« no previous file with comments | « components/nacl/renderer/plugin/pnacl_translate_thread.cc ('k') | components/nacl/renderer/plugin/utility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698